search

fedora-ci / mini-tps

Installability test for RPMs
GNU General Public License v2.0
1 stars 8 forks source link

fall back on `{dnf,yum} repoquery` if `repoquery` is not present (#47) #49

Closed AdamWill closed 6 months ago

AdamWill commented 6 months ago

https://github.com/fedora-ci/mini-tps/pull/45 changed two out of three places we previously called "$YUMDNFCMD" repoquery to instead just call repoquery (it missed one). This is because yum repoquery doesn't exist on EL 7. However, it's also not really safe to assume the standalone repoquery command will always be available either; it's part of yum-utils or dnf-utils and there's no reason to assume that will always be present. This adds a fallback, and consistently uses the command we determine across all three locations.

AdamWill commented 6 months ago

This is an alternative to #48 , it only makes sense to merge one or the other (or neither!) but not both.