search

fedora-ci / rpminspect-runner

Container image for the rpminspect pipeline
Apache License 2.0
3 stars 9 forks source link

Clean up around RPMINSPECT_WORKDIR #82

Closed msrb closed 2 years ago

msrb commented 2 years ago

This was confusing as it wasn't actually doing what one was expecting it to be doing. rpminspect was not using it as its workdir, because it was not called with --workdir param. Instead, the directory was only used as a cache for results.

Also, tmt ignores the container workdir altogether and instead calls the runner script in its own directory.

This commit makes the workdir relative to $PWD and tells rpminspect to actually use it.

Signed-off-by: Michal Srb michal@redhat.com

thrix commented 2 years ago

I think worth merging as is, the kernel test execution time went to 5h and 3 minutes \o/ on a fairly busy machine.

msrb commented 2 years ago

Yep, definitely a great improvement. Let's get this in ;)