fedora-ci / rpminspect-runner

Container image for the rpminspect pipeline
Apache License 2.0
2 stars 9 forks source link

Handle rpminspect.yaml, rpminspect.json, and rpminspect.dson local config files #93

Closed dcantrell closed 1 year ago

dcantrell commented 1 year ago

rpminspect 1.11 now supports configuration file formats in YAML, JSON, or DSON. Local configuration files can be rpminspect.yaml, rpminspect.json, or rpminspect.dson. Modify the runner scripts to support any of these existing in the git repos so they are present when the rpminspect job runs. Package maintainers can now write their local config files in any of these formats.

dcantrell commented 1 year ago

@msrb there are dist-git repos that are now gaining rpminspect.json and rpminspect.dson files, so getting this one in sooner is going to be helpful for those projects.

msrb commented 1 year ago

Thanks for the pull request.

For testing purposes, do you remember which component(s) use the new formats already?

dcantrell commented 1 year ago

I've seen it in grub2 so far.

msrb commented 1 year ago

That is a strange file format :) https://src.fedoraproject.org/rpms/grub2/blob/rawhide/f/rpminspect.dson

msrb commented 1 year ago

I am gonna push the update to Fedora CI now and let it run over the weekend. Downstream will follow on Monday ;)

msrb commented 1 year ago

Works! https://artifacts.dev.testing-farm.io/83306b00-73ef-4e00-ba72-541e69b1585a/work-rpminspect6exbt0jr/rpminspect/execute/data/rpminspect/data/viewer.html https://artifacts.dev.testing-farm.io/83306b00-73ef-4e00-ba72-541e69b1585a/work-rpminspect6exbt0jr/rpminspect/execute/data/rpminspect/data/verbose.log