fedora-cloud / docker-brew-fedora

MIT License
180 stars 46 forks source link

lack of idempotency - same images are downloaded again on each execution #63

Closed ssbarnea closed 3 years ago

ssbarnea commented 5 years ago

While tying to debug the script I found that it lacks any optimization for avoiding all images on each execution, even if they were downloaded few minutes ago.

I suspect that in CI context this is not important but for development is a readl PITA to download all these images again and again. They should be downloaded if changed.

I gues this is a side-effect of the decision to use mktemp -d for the temp directory.

I wonder if it would not be better to use a predictable folder instead and use an optional clean flag for cleaning the directory before running?

cverna commented 5 years ago

yes or add the ability to pass a directory path to the script which would make it skip downloading the images.