search

fedora-copr / copr

RPM build system - upstream for https://copr.fedorainfracloud.org/
112 stars 57 forks source link

validate wrong copr:// external repos in form #1178

Open fedora-copr-github-bot opened 1 year ago

fedora-copr-github-bot commented 1 year ago

Original issue: https://pagure.io/copr/copr/issue/1178 Opened: 2020-01-05 14:49:27 Opened by: praiskup

related to this: https://pagure.io/copr/copr/pull-request/1168

We shouldn't allow adding broken copr urls.

praiskup commented 1 year ago

Triage time: Having this 100% solved is not easy (the remote project can change the list of chroots later); but we could have at least a check when we are modifying.

rurban commented 1 month ago

Wasn't this already fixed by https://pagure.io/copr/copr/pull-request/1168 What else is to do?

FrostyX commented 1 month ago

Almost. But if you go to a project settings and put something like this in your external repositories copr://frostyx/nonexistingnonsenseproject, it will let you successfully save it even though the project doesn't exist.

It would be useful to improve the validation in frontend/coprs_frontend/coprs/forms.py to return an error message saying that such a project doesn't exist.