search

fedora-copr / copr

RPM build system - upstream for https://copr.fedorainfracloud.org/
115 stars 59 forks source link

Better typo detection in external repo field #2616

Open praiskup opened 1 year ago

praiskup commented 1 year ago

Original issue: https://bugzilla.redhat.com/show_bug.cgi?id=1811696 Opened: 2020-03-09 15:00:47 Opened by: Barry Scott

Barry Scott commented at 2020-03-09 15:00:47:

Description of problem:

I had a typo the external repo field that did not get flagged as a problem.

Version-Release number of selected component (if applicable):

How reproducible:

Put a typo into the value in the external repo field.

Steps to Reproduce:

  1. Add external repo field with a typo
  2. Do a build.

Actual results:

Build will fail without the problem with the typo being reported.

Expected results:

Helpful error message pointing to issue with external repo field.

Additional info:

Pavel Raiskup commented at 2020-03-09 15:49:34:

Thanks for the report, related to this discussion: https://lists.fedorahosted.org/archives/list/copr-devel@lists.fedorahosted.org/thread/V6TOL3ALNK42A6DAHOGNTAMFC2UBPEQB/

praiskup commented 1 year ago

We have a check for "runtime deps" now (flash saying): Non-existing projects set as runtime dependencies: copr://nonexisting/project.

But we should have this for build time deps, too.