search

fedora-copr / copr

RPM build system - upstream for https://copr.fedorainfracloud.org/
115 stars 58 forks source link

retire rpkg-util #2820

Open praiskup opened 1 year ago

praiskup commented 1 year ago

This is still our default SCM method, and as such our users are kind of motivated to use it over the other methods (e.g. even for builds from DistGit).

I think we should switch the default to tito perhaps, and start working on unwiring rpkg-util from Copr code.

praiskup commented 1 year ago

These were recently retired in Fedora, so I took them and added @copr-sig as the default assignee: 'rpkg-util', 'rpkg-macros', 'preproc', 'rpm-git-tag-sort'

FrostyX commented 1 year ago

There was some RFE for tito (I cannot find it right now) to optionally allow SRPM building on sources without needing tito init. I guess with this one feature we could switch the default SCM tool from rpkg to tito and nobody will even notice.

praiskup commented 1 year ago

The packit client maybe does (or could do) this, we need to check.

pkking commented 1 year ago

Will the new default method have ability to handle the flat source struct? like 

# tree                                                                                                                                                                                                          
.                                                                                                                                                                                                                                          
|-- xxx.tar.gz                                                                                                                                                                                                                   
|-- xxx.patch                                                                                                                                                                                                                      
`-- xxx.spec

because most our SCM repo are organized in these style.

praiskup commented 1 year ago

Good point, we should have the answer to this use-case as well.

It is unfortunate though, we have to choose the default behavior and that must be either

To not cause too much harm, I think we could keep parsing the rpkg util configuration for some time even with the future tool (either tito or packit, or some small copr-specific wrapper around it).

praiskup commented 9 months ago

FTR, related question/RFE on Tito: https://github.com/rpm-software-management/tito/issues/472