fedora-copr / copr

RPM build system - upstream for https://copr.fedorainfracloud.org/
113 stars 61 forks source link

Custom Webhook now adds a record in Webhook History table #3456

Closed jaitjacob closed 1 month ago

jaitjacob commented 1 month ago

Custom Webhooks are not expected to send a UUID. Instead the UI checks for None passed for Webhook UUID and prints "Custom Webhook" instead. See below, image

Fix #3455

jaitjacob commented 1 month ago

@FrostyX You may notice redundant db.session.commit() in webhook_general.py. I couldn't avoid them cause until we explicitly commit, 1.id is not generated and that results in an error

  1. Webhook History table does not update with the latest webhook info
praiskup commented 1 month ago

Thank you very much for the quick turn-around. There's no need to send those simple fixes as drafts ;-)

praiskup commented 1 month ago

Thank you very much for the update; I'd just store NULLs for the user agent if not known, otherwise LGTM