search

fedora-copr / log-detective-website

Data collection page for Log Detective AI
11 stars 7 forks source link

pre-commit: disable autofixes #119

Closed nikromen closed 1 month ago

nikromen commented 3 months ago

the pre-commit github action behaves weirdly sometimes #63

using pre-commit-ci app (or just running it via command in github action) should solve this

nikromen commented 3 months ago

oh no, seems like the ci doesn't like the cljs hooks :/ I'll try later if it's possible to make it work

nikromen commented 2 months ago

@FrostyX the cljfmt-docker seems to be unmantained for long time and broken :/ is there any alternative we can use or not?

or we can make our own hook

FrostyX commented 2 months ago

is there any alternative we can use or not?

There is that thing I added before we migrated to pre-commit. Maybe we can use that?

nikromen commented 2 months ago

That's indeed possible and probably the easiest way. But this way we will lose the ability to test it locally in an isolated environment (it will be tested only in GH actions). The main users of cljs linters are probably you @Fan @FrostyX . Would you mind having these linters separated from pre-commit and running only in GH actions (this way we can even drop the pre-commit action and use only the pre-commit.ci app)? If not I can still create our own hooks - it's not hard, it's just more work.

nikromen commented 2 months ago

it's green again \o/