fedora-copr / log-detective-website

Data collection page for Log Detective AI
11 stars 7 forks source link

Add test for fetchers #57

Closed nikromen closed 4 months ago

nikromen commented 7 months ago

Fixes #40

TODO:

nikromen commented 4 months ago

I'm curious, why did you create the additional level of hierarchy with the src/ subdirectory?

because I had to create tests directory. I had 2 options - do it in the repo root which doesn't make sense since there's backend and frontend dir as monorepos (and frontend also src/) and I would put tests dir for backend but outside of the backend subrepo.

The other option was to put tests directly to backend but then there will be code and then randomly a test dir :/ So I created this hierarchy - also it is easier to run these tests inside makefile since the code and tests are close to each other

Yep... it was bad idea from me at the beginning to put the code right in the backend monorepo root dir