search

fedora-copr / vcs-diff-lint-action

Differential code linting GitHub action
2 stars 1 forks source link

Avoid the ubiquitous GitHub github-code-scanning PR message #16

Closed praiskup closed 1 year ago

praiskup commented 1 year ago

We have to specify the 'push' target. This avoids the message:

You have successfully added a new vcs-diff-lint configuration
.github/workflows/python-diff-lint.yml:python-lint-job. As part of the
setup process, we have scanned this repository and found no existing
alerts. In the future, you will see all code scanning alerts on the
repository Security tab.

... in every single PR. Without 'push' defined GitHub thinks that the linter action is added in every single pull-request.

While on it, move the 'if' statements down so the rules are slightly more readable.

Related: redhat-plumbers-in-action/differential-shellcheck#215

praiskup commented 1 year ago

@jamacku would you mind taking a look?

praiskup commented 1 year ago

This doesn't seem to work actually. https://github.com/fedora-copr/flask-whooshee/pull/78

praiskup commented 1 year ago

Closing in favor of #17.