search

fedora-copr / vcs-diff-lint-action

Differential code linting GitHub action
2 stars 1 forks source link

In pull-request, we should diff against ${{ github.event.pull_request.base.sha }} #18

Open praiskup opened 1 year ago

praiskup commented 1 year ago

Not against the (possibly updated) freshly checked-out origin/main branch.

This is the problem: https://github.com/fedora-copr/vcs-diff-lint-action/blob/0d6348a73d257cd7212462bda3da680c0479b681/container/cmd#L69

The generated diff might be unnecessarily big if a different pull-request was merged in the meantime.