search

fedora-infra / anitya

A cross-distribution upstream release monitoring project
https://release-monitoring.org
GNU General Public License v2.0
250 stars 105 forks source link

Check of an invalid mapping #1093

Open frenzymadness opened 3 years ago

frenzymadness commented 3 years ago

Somebody for some reason changed a mapping for pip project for Fedora from python-pip to python3-pip. This caused that we no longer had bugzillas for new releases. We have fixed it back to the correct package.

I completely understand that it's not possible to verify all mappings but since you already create a link to https://src.fedoraproject.org/rpms/<package_name> would it be possible to check that URL and if it responses with HTTP 404, then refuse to change the mapping? It's an easy way how to check that the package in the Fedora really exists.

Thanks a lot for the great project you maintain and let me know if I can contribute and implement this feature.

Zlopez commented 3 years ago

We don't really create the links, it's just in HTML template as https://src.fedoraproject.org/rpms/<mapping>, the validation is done on the level of the-new-hotness, which creates the issues in bugzilla.

It's possible to add the validation, when the user creates/edit mapping and we could check it and return error if the link is not accessible. But first we need to implement this https://github.com/fedora-infra/anitya/issues/1066

Zlopez commented 2 months ago

Another option here is to have a job that will once a month could just check all the links and remove those that are returning 404 now.