fedora-infra / anitya

A cross-distribution upstream release monitoring project
https://release-monitoring.org
GNU General Public License v2.0
250 stars 105 forks source link

pylint anitya/admin.py #1598

Closed lmilbaum closed 1 year ago

softwarefactory-project-zuul[bot] commented 1 year ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/4a66099f422c4e88a82589ee1d5085a5

:x: fi-tox-mypy FAILURE in 10m 24s :x: fi-tox-lint FAILURE in 10m 12s :x: fi-tox-format FAILURE in 10m 29s :x: fi-tox-python38 FAILURE in 11m 33s :x: fi-tox-python39 FAILURE in 11m 32s :x: fi-tox-python310 FAILURE in 11m 22s :x: fi-tox-python311 FAILURE in 11m 05s :x: fi-tox-docs FAILURE in 11m 35s :x: fi-tox-bandit FAILURE in 10m 15s :x: fi-tox-diff-cover FAILURE in 11m 36s

softwarefactory-project-zuul[bot] commented 1 year ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/eafe03c736044062a0c5a54758d6f7d6

:heavy_check_mark: fi-tox-mypy SUCCESS in 10m 03s :heavy_check_mark: fi-tox-lint SUCCESS in 9m 35s :x: fi-tox-format FAILURE in 9m 28s :heavy_check_mark: fi-tox-python38 SUCCESS in 13m 02s :heavy_check_mark: fi-tox-python39 SUCCESS in 13m 43s :heavy_check_mark: fi-tox-python310 SUCCESS in 12m 45s :heavy_check_mark: fi-tox-python311 SUCCESS in 12m 37s :heavy_check_mark: fi-tox-docs SUCCESS in 10m 35s :heavy_check_mark: fi-tox-bandit SUCCESS in 9m 43s :heavy_check_mark: fi-tox-diff-cover SUCCESS in 14m 20s

softwarefactory-project-zuul[bot] commented 1 year ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/272979e8a1ba41f7a85510439ecd47af

:heavy_check_mark: fi-tox-mypy SUCCESS in 14m 27s :heavy_check_mark: fi-tox-lint SUCCESS in 13m 39s :heavy_check_mark: fi-tox-format SUCCESS in 13m 34s :heavy_check_mark: fi-tox-python38 SUCCESS in 18m 17s :heavy_check_mark: fi-tox-python39 SUCCESS in 18m 16s :heavy_check_mark: fi-tox-python310 SUCCESS in 18m 18s :heavy_check_mark: fi-tox-python311 SUCCESS in 19m 07s :heavy_check_mark: fi-tox-docs SUCCESS in 16m 08s :heavy_check_mark: fi-tox-bandit SUCCESS in 14m 12s :x: fi-tox-diff-cover FAILURE in 22m 06s

softwarefactory-project-zuul[bot] commented 1 year ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci https://fedora.softwarefactory-project.io/zuul/buildset/3e5a66635bcd43b8ba5add8351cbe630

:heavy_check_mark: fi-tox-mypy SUCCESS in 10m 37s :heavy_check_mark: fi-tox-lint SUCCESS in 10m 21s :heavy_check_mark: fi-tox-format SUCCESS in 10m 13s :heavy_check_mark: fi-tox-python38 SUCCESS in 14m 22s :heavy_check_mark: fi-tox-python39 SUCCESS in 13m 51s :heavy_check_mark: fi-tox-python310 SUCCESS in 15m 45s :heavy_check_mark: fi-tox-python311 SUCCESS in 14m 14s :heavy_check_mark: fi-tox-docs SUCCESS in 11m 35s :heavy_check_mark: fi-tox-bandit SUCCESS in 10m 13s :x: fi-tox-diff-cover FAILURE in 16m 09s

lmilbaum commented 1 year ago

@Zlopez Would you mind taking a look at the CI error. I can't figure out what have changed in line 269 which produced the coverage error.

Zlopez commented 1 year ago

@lmilbaum Looking at it and it seems that the line wasn't covered by tests before and when you changed it it started complaining.

You can either create a test for it or we can merge it as it is.

lmilbaum commented 1 year ago

@lmilbaum Looking at it and it seems that the line wasn't covered by tests before and when you changed it it started complaining.

You can either create a test for it or we can merge it as it is.

Thanks for looking into it. I'd prefer to merge it as it is if that works for you.