search

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.
https://bodhi.fedoraproject.org
GNU General Public License v2.0
153 stars 195 forks source link

Bodhi is using a transaction manager around fedmsg which may not be neccesary #1078

Closed bowlofeggs closed 7 years ago

bowlofeggs commented 7 years ago

It may be possible to drop this code:

https://github.com/fedora-infra/bodhi/blob/2.3.1/bodhi/server/notifications.py#L82-L200

@puiterwijk suggested that this code is meant to work around fedmsg not handling threads well, but it is believed that fedmsg is well capable of working within threads. We should double check that, and if it is safe we should drop that code and fix whatever was using it to use fedmsg directly.

jeremycline commented 7 years ago

I don't think this is relevant anymore since we dropped transaction