search

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.
https://bodhi.fedoraproject.org
GNU General Public License v2.0
152 stars 193 forks source link

Bodhi is now sending two identical emails when a package meets its karma requirement (and autopush is enabled) #1403

Closed dhgutteridge closed 3 years ago

dhgutteridge commented 7 years ago

Recently, Bodhi began behaving differently: instead of sending an email listing the details of the final karmic input that caused a package to meet requirements to be pushed to stable, and then a second email indicating the package has been submitted for stable, it now sends two copies of the latter. I'm not sure if this is the result of someone trying to fix #1210, or some other cause, but it seems broken for every package I've commented on of late.

bowlofeggs commented 7 years ago

@dhgutteridge Could you link a couple or three example updates that have had this issue? I've not noticed it with my updates.

dhgutteridge commented 7 years ago

Sure, I've listed three examples below. This only affects the emails sent, the web display of Bodhi shows everything correctly. In each case, I received two emails with the same time stamp saying the package was submitted for stable, and no email listing the final feedback that pushed it.

https://bodhi.fedoraproject.org/updates/FEDORA-2017-a20103b1c8

(There's a separate issue with this one: Bodhi shows +2 karma in the summary, when +3 is required to push, yet it actually has +3 karma from the comments, and is being pushed to stable.)

https://bodhi.fedoraproject.org/updates/FEDORA-2017-fab848dafc

https://bodhi.fedoraproject.org/updates/FEDORA-2017-aad1da140f

dhgutteridge commented 7 years ago

Actually, when looking through the message headers, the two emails don't have identical time stamps, they vary by a couple of seconds.

bowlofeggs commented 7 years ago

Can you provide headers for those two that vary by a few seconds? Feel free to sanitize any info you don't want to share on the Internet.

The karma count problem is known, and has been fixed on the develop branch: https://github.com/fedora-infra/bodhi/issues/829 The fix should be included with whatever release happens after 2.5.0.

dhgutteridge commented 7 years ago

Sure, here are the full emails.

Email one:

`Received: from SN1NAM01HT154.eop-nam01.prod.protection.outlook.com (10.172.104.34) by BN6PR18MB1268.namprd18.prod.outlook.com with HTTPS via BN6PR07CA0048.NAMPRD07.PROD.OUTLOOK.COM; Sun, 2 Apr 2017 15:54:35 +0000 Received: from SN1NAM01FT022.eop-nam01.prod.protection.outlook.com (10.152.64.59) by SN1NAM01HT154.eop-nam01.prod.protection.outlook.com (10.152.65.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1005.5; Sun, 2 Apr 2017 15:54:35 +0000 Authentication-Results: spf=none (sender IP is 209.132.181.2) smtp.mailfrom=fedoraproject.org; hotmail.com; dkim=pass (signature was verified) header.d=fedoraproject.org;hotmail.com; dmarc=bestguesspass action=none header.from=fedoraproject.org; Received-SPF: None (protection.outlook.com: fedoraproject.org does not designate permitted sender hosts) Received: from COL004-MC6F35.hotmail.com (10.152.64.58) by SN1NAM01FT022.mail.protection.outlook.com (10.152.65.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1005.5 via Frontend Transport; Sun, 2 Apr 2017 15:54:35 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:E04AA22349D4A90C22021116D7D3965CBC1A95675969E7B790BB42FD88EFF00F;UpperCasedChecksum:BBE5F28AE92D3506AA76FF595927367D63EC1144B24320AF5C72D3ED1F5D7EF4;SizeAsReceived:1719;Count:22 Received: from bastion.fedoraproject.org ([209.132.181.2]) by COL004-MC6F35.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23143); Sun, 2 Apr 2017 08:54:34 -0700 Received: from bodhi04.phx2.fedoraproject.org (bodhi04.phx2.fedoraproject.org [10.5.126.116]) by bastion01.phx2.fedoraproject.org (Postfix) with ESMTP id D106E601FBF2 for dhgutteridge@hotmail.com; Sun, 2 Apr 2017 15:54:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 bastion01.phx2.fedoraproject.org D106E601FBF2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fedoraproject.org; s=bastion; t=1491148473; bh=m9tUQqkHEEv1C2nD2witBnBjkK8vG427+TLswaVFhC0=; h=From:To:In-Reply-To:References:Subject:Date:From; b=UTXeH2lnZe7jGmcKFz3BXjL/hLrStiJwDsLyc8WnHqzXVfB5E87H7qZxw82AoMofZ hk0xeiVXkq9eGi6yahefM7Swot2WGca5k2D6nWyka8A0FWsX12xEem7ba5L4kZgDdC aTxnmZmRxcjQWhffKsZa9Id/jvQVM8yN/Jye311Q= From: updates@fedoraproject.org To: dhgutteridge@hotmail.com X-Bodhi-Update-Builds: audacity-2.1.3-2.fc25 In-Reply-To: bodhi-update-83479-dtimms-F25@admin.fedoraproject.org X-Bodhi-Update-Pushed: True X-Bodhi-Update-Type: bugfix X-Bodhi-Update-Release: F25 References: bodhi-update-83479-dtimms-F25@admin.fedoraproject.org X-Bodhi-Update-Status: testing X-Bodhi-Update-Request: stable X-Bodhi-Update-Submitter: dtimms X-Bodhi-Update-Title: audacity-2.1.3-2.fc25 X-Bodhi: fedoraproject.org Subject: [Fedora Update] [comment] audacity-2.1.3-2.fc25 Message-ID: 20170402155433.D106E601FBF2@bastion01.phx2.fedoraproject.org Date: Sun, 2 Apr 2017 15:54:33 +0000 (UTC) Return-Path: updates@fedoraproject.org X-OriginalArrivalTime: 02 Apr 2017 15:54:34.0491 (UTC) FILETIME=[6C89C4B0:01D2ABC9] X-IncomingHeaderCount: 22 X-MS-Exchange-Organization-Network-Message-Id: f2bd80fd-774d-41ae-0486-08d479e08f82 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa:0 X-MS-Exchange-Organization-MessageDirectionality: Incoming CMM-sender-ip: 209.132.181.2 CMM-sending-ip: 209.132.181.2 CMM-Authentication-Results: hotmail.com; spf=none (sender IP is 209.132.181.2) smtp.mailfrom=updates@fedoraproject.org; dkim=pass header.d=fedoraproject.org; x-hmca=pass header.id=updates@fedoraproject.org CMM-X-SID-PRA: updates@fedoraproject.org CMM-X-AUTH-Result: PASS CMM-X-SID-Result: PASS CMM-X-Message-Status: n:n CMM-X-Message-Delivery: Vj0xLjE7dXM9MDtsPTE7YT0xO0Q9MTtHRD0xO1NDTD0w CMM-X-Message-Info: NhFq/7gR1vTvTqmPqDcS3WCSsAN31lchiBtReiwcNAKcHZ2G1uT8VEQvds/L9PzmRnmWSE1zVKO8zeDl0qwF6404lipiC9McSvXmB/uXD0y1XVWNP1zfqvawlVbvMkiUgIpWGCwb/+KZcZpzs4P9drM8/8RTekffrKBHdl7plJirBhOQfXoBmW4MpU03eB1hVn2BfbI+6GJ9cWnOOcJ8+uo1J7kAJP1EnNMicjzPCc3DqBB9rAVHgdBZLfVAq/zn X-MS-Exchange-Organization-PCL: 2 X-Microsoft-Exchange-Diagnostics: 1;SN1NAM01FT022;1:siArER8GYoJztPfjUZAoikUyOxJ56FoGEc7CadzmtToTQsyWwyUut4RdkDVRldmgyLheBDFWi/I0BFJeUvJlDFIw486tCKbaAMRpxu1A8dtu3fmQy4eY6l6gf6OTEdv/R5w3MxvWJ4hUPFNwCxQoAs8QsDjC+OJdjbcSfpfs6PYkgW8PMMjGvM5bvXOF95oW X-Forefront-Antispam-Report: EFV:NLI;SFV:NSPM;SFS:(98901004);DIR:INB;SFP:;SCL:1;SRVR:SN1NAM01HT154;H:COL004-MC6F35.hotmail.com;FPR:;SPF:None;LANG:en; Content-Type: text/plain X-MS-Exchange-Organization-AuthSource: SN1NAM01FT022.eop-nam01.prod.protection.outlook.com X-MS-Exchange-Organization-AuthAs: Anonymous X-MS-Office365-Filtering-Correlation-Id: f2bd80fd-774d-41ae-0486-08d479e08f82 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(22001)(8291500097)(8291501071);SRVR:SN1NAM01HT154; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM01HT154;3:D1NCmAwObv1Rv4+AKx1QX2iTOX/sDaI9aWuhlLD3ouoG2/Bs/voJm4zMUzLGdY5YkAqsMVEtOPwVzHCWxgkyUY+ib4aIDhspr7d/DULq5C27N3IexdYSeeDmA2+aI9II5OfMmeWAPsN6jIG9c0cIEd+HDeNM+u3SAMLlt9cKcE+NYMak7qH4X+HQElRNv0i6eQUoEQO1J37cXuX5Kze7LM1KTI/PSl7way2iAZzWK8PHXv1XbVZPEazxOaFZQHH5RAgcjAxXpe2rgZRh9Osvjh7GmxwwSboMXNocZrefKMGLGtMqqVFCzqdi1If4vMr4z6FeAxtp/DNzbUxSTCR+exY9L+F3UzB0IolpMMcTjwcw7S2RB9Q+O7PF4OJpFfsaMXe3k9zrhCqQsk6gRzAM2g==;25:EGmBzT01oGk/MYwmGFfJSS7VnQzXNX8rFY0Hnuqslp9WwhqTxD26oyJMq+3V8Tuj32X4nfh7wwqpa7/TWZlxnKjwZqg9DC0z86CJ00TFFjYI2F/SxFV8oRnVyJN76TFfT8TbbFxSCAlJGc1ZoNoy45uZD9KWau2t6n0qsitQIItVfOh/pTYjM4Uzm76pI91qytS6e9zbATq+hqZd/g3MH7Z9W5o+vhahdWfSBWeTrCXUeSSzHtuo6ORWvgxp00phQEDu4dbegW3VXUTW7QXQb/k1vsoCuc3f252d+88pyKsGYCBlPNM9gmIV7lJroQ9/JdkFiaJcXA9yExQ9GcideOaXJcEysH6Wxw79JY4DnVHwYO8Yau3kF8KEa4/mr9upNOFk1l9WrhnwhXc0wRsXxlAgalgzwnLDmgpWdmyZuKj6JEMNc5R4prvqLlrhd6W6kCeWAFzGmk56o0XwEx28fi6OSN3ndrMGSnAKHWe2IlY= X-MS-Exchange-Organization-AVStamp-Service: 1.0 X-Microsoft-Exchange-Diagnostics: 1;SN1NAM01HT154;31:ivwHyGHNlr7dMNWSCqak+gwV/ZLYH5/ejjOwacc+rF2Nw0Ldxgz7M+nWttVUbrheVomnQ/DqnuwSHCl3SzkHG2Ij89FB9Pe/DjSmI0dBwgdaI0ozLUpX/S8fQggK1rQWwX5Ku56DYZVyrm1imF3sdYLIb1xuQCC8mZujrWO3rs80Q8M5OIRc+g/1THCVR03NMkkYcjIQzMmWSKhm0EnLDNK3vO07SBBqvZOV4HaG2FThd0w4yYP19TbJG5iid5wXdqyuwDxk7MpmHKFUyYF0TWI9jGROu56UCUmpAU1CyK/uGF3qeQyqwgYGYgNj0SEG;4:89/DWq9O/k8UruhABh1tdKdRvGPYvKcTQl8vgy6HLmuZO4lpvBoTiywUAo6D0Hi01Cjbfbty63Zu2ZXv1UfaV/L+fFspgqq9bmKf8Ve+zX3pr4w1kJRA+NsLdYEDqgX7ttJ804Qi0kA4+CBTtg38F8jOFMKTStPG6bdPbQynCrTIxp4ofXeI6VHNjuVDkhQ0Skukcwu3UIKeiTNIpGTfd9J41PmnQA1p4+BvGqPJgKvBEl0LW0Ll0lWqfdF6ErJV4CrF8VzdNcxmCDw/XXE8yea7KtS6tuSUh1QhHsEGg/ju2v3Z0YmGvtiAlJk+cu8X;23:xxvxF49PmPpocJHH2XdQL8YsG/heJUc4+YyKDXJqOsaBque8n3psgHsX7ehvwYR6vyweYGG+6kEfFQgErX7NbBeKYXj18Oh3AxTHjzabD7lxxGCcvGz8KfaGyAOEsyMt1rO5kwXAVrsM8xC8D+31pgGG1JeqdsFcwhYXLC6M2jY= X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(444111366)(82015058);SRVR:SN1NAM01HT154;BCL:0;PCL:0;RULEID:;SRVR:SN1NAM01HT154; X-MS-Exchange-Organization-SCL: 1 X-Microsoft-Exchange-Diagnostics: 1;SN1NAM01HT154;6:kmfHLazgBOY8RLO5jkEJgpGFuGOdbEp/Bf6pcBBvxHwSMhXfpfiqEkhVL5qDKNpm4wrNva74M5CsKMnxWLocOKrr+mHO9aokvZFFCNaNc5K0P1Q9FCM3AJOqh76Q8V5PuD7Mr1mOQUIz6VmjsHeSm7v+jioYP44RC+YlhDZTAWQfla1HpaQPhryjcf5mitqbdwHqiZgdO5C2sWPfN7EwZCNg9hv5gBpuGZJ8WwZRYlGClLyMxmJbBM0GX183BGjqlMN6hRgbxnopznsb0nkqgfZHNXRb6v4hcVQUjvEyVFsdGRh9P+SWLcp0xEIJBbLKO2EYKuUj7JN+CmY6Vd8BEKhZ0lryXXTylPdryZ0OJtMdV12y/IVrMtjOtNhSmp6bP92YjG9CBLwPaI3GYnoMqg==;5:CdrGBkH9GtjRxjc+FtaMrTxqRaKkEdlqLf1fddH4KrpRi8ooMLlso2M7zOhxDhNmRF6l7Fo1e21lTbWnd3qRIrXMIaL4AnXPsdoiFWF7IscQu2w9yLtjyvNvzXu61Q5BMxa4gOKbTbiydcc8t6hufYNOhs2chLlfWGvDr3HREiM=;24:iU9kfpvJRripghho8CBj7HpZC2R9XRV/OFFB+vjuz3pQSFRaano+3CdqbupL+sCotdpzSZ6zS1hlgpS9JqUiCtEZTrPf5OdLRKeXGUevs4E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1NAM01HT154;7:PfsZSuNCqDoQohC8QZIRWBdoceJa8X1U8ntuMIS89/Qqlt90VD4y9MBXCHtH9SUJMkFk89x2vSRX5gGrZx6rRf5tCbspyBWZn57CmrnRPFIbxraqwVspqRRwmrbL+bbnuRrAe0n6VDKb0MNqfldlGDnomYVFm6mYwmty4bNyw6+FQpy/SpZnXz63/2mFGFleWsh2+OjHwziMQdlFXU/h6i1qfT72v+FJpW+IimE6Pp8GzeQfNmRblh6JoP31GPzybtYeyUQzrpWz1HlxhIojIQal+O0t+LN9JsWd6Zb8Fne3kmqL43qsApJyZF9NLVj5fGUlGBtuY1pUDHchQe9q0Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2017 15:54:35.0868 (UTC) X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM01HT154 X-MS-Exchange-Transport-EndToEndLatency: 00:00:00.7380503 X-Microsoft-Exchange-Diagnostics: 1;BN6PR18MB1268;27:l/x4wiiiaXiJ8xyDLERUr/hyeKP/jsYZUVu16yWhpnHf5wV9a++geO26Pn79IznJwQGeFLgTfSLD6mX7ylecZyOZG5HpkBf7WJBe6F98JIX54V3HnIqF+e8b+3GneNCmWWRJb8CpPUi1ABV8lt3cJw== X-Microsoft-Antispam-Mailbox-Delivery: abwl:0;wl:1;pcwl:1;iwl:0;rwl:0;ex:0;auth:1;dest:I;WIMS-SenderIP:209.132.181.2;WIMS-SPF:fedoraproject%2eorg;WIMS-DKIM:fedoraproject%2eorg;WIMS-822:updates%40fedoraproject%2eorg;WIMS-PRA:updates%40fedoraproject%2eorg;WIMS-AUTH:PASS;ENG:(5061607094)(102400140)(102409045);OFR:TrustedSenderList; MIME-Version: 1.0

The following comment has been added to the audacity-2.1.3-2.fc25 update:

bodhi - 2017-04-02 15:54:33.387138 (karma: 0) This update has been submitted for stable by bodhi.

To reply to this comment, please visit the URL at the bottom of this mail

================================================================================ audacity-2.1.3-2.fc25

Update ID: FEDORA-2017-a20103b1c8 Release: Fedora 25 Status: testing Type: bugfix Karma: 3 Request: stable Bugs: 1397150 - None : 1423191 - None : 1413341 - None : 1408706 - None : 1402830 - None : 1398446 - None Notes: #Audacity 2.1.3 release. ##New Features: - MP3 import without : additional package repository. - Distortion effect, : Rhythm Track and Sample Data Import. - Scrub Ruler. - : Pinned waveform option. - Timer Record enhancements. : ##Other Changes: - many bugs and annoyances resolved. : See [Audacity Team release announcement](http://www.au : dacityteam.org/audacity-2-1-3-released/). Submitter: dtimms Submitted: 2017-03-26 05:57:00.163080 Comments: bodhi - 2017-03-26 05:57:00.257780 (karma 0) This update has been submitted for testing by dtimms. bodhi - 2017-03-27 03:21:03.590619 (karma 0) This update has been pushed to testing. dhgutteridge - 2017-03-27 13:53:01.674237 (karma 1) No regressions noted. (The microphone input slider doesn't respond, it's stuck at 100% -- and it doesn't reflect the actual state of the microphone input setting -- but that's not a regression from the previous version, audacity-2.1.3-0.7.20161109git53a5c93.fc25.) baggypants - 2017-04-01 09:19:12.432999 (karma 1) Loads and runs as expoected applied a couple of effects to an mp3 seems ok sassam - 2017-04-02 15:54:32.109649 (karma 1)

`

Email two:

`Received: from CY1NAM02HT104.eop-nam02.prod.protection.outlook.com (10.172.104.19) by BN6PR18MB1268.namprd18.prod.outlook.com with HTTPS via BN6PR07CA0033.NAMPRD07.PROD.OUTLOOK.COM; Sun, 2 Apr 2017 15:54:37 +0000 Received: from CY1NAM02FT037.eop-nam02.prod.protection.outlook.com (10.152.74.53) by CY1NAM02HT104.eop-nam02.prod.protection.outlook.com (10.152.74.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1005.5; Sun, 2 Apr 2017 15:54:37 +0000 Authentication-Results: spf=none (sender IP is 209.132.181.2) smtp.mailfrom=fedoraproject.org; hotmail.com; dkim=pass (signature was verified) header.d=fedoraproject.org;hotmail.com; dmarc=bestguesspass action=none header.from=fedoraproject.org; Received-SPF: None (protection.outlook.com: fedoraproject.org does not designate permitted sender hosts) Received: from SNT004-MC3F52.hotmail.com (10.152.74.54) by CY1NAM02FT037.mail.protection.outlook.com (10.152.75.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1005.5 via Frontend Transport; Sun, 2 Apr 2017 15:54:37 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:29469E288C02453B7DBCA8144C0F6A39BCE29D04B173D9F770F7E6EDB6289B64;UpperCasedChecksum:09B56909FF769E1C355A1731B896CAB26DCE9334A45851C8B1D21AF77074BBAE;SizeAsReceived:1719;Count:22 Received: from bastion.fedoraproject.org ([209.132.181.2]) by SNT004-MC3F52.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23143); Sun, 2 Apr 2017 08:54:36 -0700 Received: from bodhi04.phx2.fedoraproject.org (bodhi04.phx2.fedoraproject.org [10.5.126.116]) by bastion01.phx2.fedoraproject.org (Postfix) with ESMTP id AEC6F604E473 for dhgutteridge@hotmail.com; Sun, 2 Apr 2017 15:54:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 bastion01.phx2.fedoraproject.org AEC6F604E473 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fedoraproject.org; s=bastion; t=1491148475; bh=m9tUQqkHEEv1C2nD2witBnBjkK8vG427+TLswaVFhC0=; h=From:To:In-Reply-To:References:Subject:Date:From; b=GpOFR++lncU1TS68OnSvpO6TQs2oUzTpp+RJVCyUrOjRGf+wfJxowY1gioMpcd7qs FgsWGUWoDxIuOxaQT8WxqJtL58CU/5VI5n/JZ9hzqF4c9ULTM+Wkz8f4Zg2XTx83QC sPq6j4lOQWWKTQVwAVSERb1pddHhtu5fzi5L9CR8= From: updates@fedoraproject.org To: dhgutteridge@hotmail.com X-Bodhi-Update-Builds: audacity-2.1.3-2.fc25 In-Reply-To: bodhi-update-83479-dtimms-F25@admin.fedoraproject.org X-Bodhi-Update-Pushed: True X-Bodhi-Update-Type: bugfix X-Bodhi-Update-Release: F25 References: bodhi-update-83479-dtimms-F25@admin.fedoraproject.org X-Bodhi-Update-Status: testing X-Bodhi-Update-Request: stable X-Bodhi-Update-Submitter: dtimms X-Bodhi-Update-Title: audacity-2.1.3-2.fc25 X-Bodhi: fedoraproject.org Subject: [Fedora Update] [comment] audacity-2.1.3-2.fc25 Message-ID: 20170402155435.AEC6F604E473@bastion01.phx2.fedoraproject.org Date: Sun, 2 Apr 2017 15:54:35 +0000 (UTC) Return-Path: updates@fedoraproject.org X-OriginalArrivalTime: 02 Apr 2017 15:54:36.0479 (UTC) FILETIME=[6DB91CF0:01D2ABC9] X-IncomingHeaderCount: 22 X-MS-Exchange-Organization-Network-Message-Id: 66713c33-3ecb-4413-18f8-08d479e090c1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa:0 X-MS-Exchange-Organization-MessageDirectionality: Incoming CMM-sender-ip: 209.132.181.2 CMM-sending-ip: 209.132.181.2 CMM-Authentication-Results: hotmail.com; spf=none (sender IP is 209.132.181.2) smtp.mailfrom=updates@fedoraproject.org; dkim=pass header.d=fedoraproject.org; x-hmca=pass header.id=updates@fedoraproject.org CMM-X-SID-PRA: updates@fedoraproject.org CMM-X-AUTH-Result: PASS CMM-X-SID-Result: PASS CMM-X-Message-Status: n:n CMM-X-Message-Delivery: Vj0xLjE7dXM9MDtsPTE7YT0xO0Q9MTtHRD0xO1NDTD0w CMM-X-Message-Info: NhFq/7gR1vTvTqmPqDcS3WCSsAN31lchiBtReiwcNAKcHZ2G1uT8VEQvds/L9PzmRnmWSE1zVKO8zeDl0qwF6404lipiC9McSvXmB/uXD0y1XVWNP1zfqvawlVbvMkiUgIpWGCwb/+KZcZpzs4P9drM8/8RTekffrKBHdl7plJirBhOQfXoBmW4MpU03eB1hVn2BfbI+6GJ9cWnOOcJ8+uo1J7kAJP1EnNMicjzPCc3DqBB9rAVHgdBZLfVAq/zn X-MS-Exchange-Organization-PCL: 2 X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT037;1:pXWFTcGKgwGKUWVbnyryiwvoaproBnOnjC5DMfeOR3rRWS0sOyRNF1J9Z/6vHxyaZ6zZYMLDtrDtzXKgUYqS8ZqmyRoOC+S3mlVCXtF8/NQT8/W2hZCQ81Acb0tBfaCIH8MeeuwVe76L44n9fsO/tHPVE163JCbKAvz91LXpyKqq2i0uXQpGhqfD+jludGUc X-Forefront-Antispam-Report: EFV:NLI;SFV:NSPM;SFS:(98901004);DIR:INB;SFP:;SCL:1;SRVR:CY1NAM02HT104;H:SNT004-MC3F52.hotmail.com;FPR:;SPF:None;LANG:en; Content-Type: text/plain X-MS-Exchange-Organization-AuthSource: CY1NAM02FT037.eop-nam02.prod.protection.outlook.com X-MS-Exchange-Organization-AuthAs: Anonymous X-MS-Office365-Filtering-Correlation-Id: 66713c33-3ecb-4413-18f8-08d479e090c1 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(22001)(8291500097)(8291501071);SRVR:CY1NAM02HT104; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT104;3:bZczMND6jTcjY97GsAjzWKsIxj2Kn7NVNAsqYS7+ZmQ+miumqesnDnSvrcj8Sv1SVK8pjp0xhxbVECkcvWP053MXBoaVEdFEbWqkf8X8WNA2lzpw1Obtgr4HEBW8i2S5K/qa1ccMs4jUBjneIXKIN+ItxoItQEMfjASD3KfwhB7VuAL7g40s2pXz/nkaT6iFCoTbDbDc59eugQeFkYzPOAgHZoJK7IDOQlrLXDVVhKoapnuj4EKs3meav9rsMl6gudGRk+0wBB2sDZ4FzyIqaQmaNYG/Ed579IrkOlU0Sc/pj/wRGfh+0qwy01U5iogO6+lWCiaTJJ+nt/ECfXSQ6eqlN3HEruVo+pqnzCUIXsxyLVQ886FAIZvBYYsDj6hP1X0BFbcYP46Lk1GHg2iwbA==;25:fhhzqy+wDa+lag5qpFNY4+SfoGA5jpuQXnIOASOIMauS73J54QivSlYYt7y5XRCN4JsmNGbvmlJaWiFENdyQJQYNEd0cRPJPZQw1UAJLOQUKRH3C9XqYDe8mGNOsNY8eX8flGH1tJH017nsJCRikq0+ISs8QqrZDLa9+oUrLj35FD6l8FPn+MVN8DU14UKwWhWW7gTQrRtirWvHLYDEKc/fbus8CXsM9YXQlOOjE8NzAKpMDYRXTj2HQ1omMpbLgc03rhMqVG7XxduBEIjGk6RjMaAQpeRed/sXWK7zEZOhpFNWmMcpM2sBykfMbIUpgrDH/D6+4pLPhM+mQ+sDmDnlENRAdqyyreQTDr/fK2Cp5QyCXiJjJf2m0g5FrR6Q96sIMiBG657xQ63dyaFTNzT/wOZm15au5Hz7F/ziMud/ZdMR614WKRnULkCj7dMKzuntIUQgpuq5olB8Mdk8cqbd0RBG/HA5ZNED6AG2K4gI= X-MS-Exchange-Organization-AVStamp-Service: 1.0 X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT104;31:rvCiNpQNhlR1wXI4wUwm0N2YWh0F581qrfBS8K6CFv0tyJPYlephVBYwQf6iIDmW0tLs1j+bzO6/uDFu4okPtGGa/t6dFQBYQ+G5fhud1e+7c9zJbbh1leehmIJugnQqorq0RuJT31+vAX9TYTyWhRB+nNOtrGSUZwZj8X/BMamQhACeTqWFapB4jz0idcdJc5pMmV8n31jK3KNCYSsV6xUB+ogu+hBx7mD4LHoiSg9Z1vDacDLyW/u81I/L8+SPdvQusJxnCKH6vkkv1pW5C+6lBS0FWlBAtLwKUF0FP4ftg/RC7wMb8mmbo8JofLnq;4:lWgzTl7X6kWq3hpL2LmorH1JHLB3G46Mnl8B1+y5LyJMtNtKJYfnojrFECUwpYPW+KCA4dEA4I7WG11+c8wFFM76rdm9baMmXmTx80LnN4tmcFZyB3R9Cgis74s8wafPJ3CqpFKQXuIzEkbF5i6796nnUt2/h3HgVeoUpoh15UY68T3V5Ys5efXxNddlgHeJD9FqB1SMf6Z/SVueFZF21g31e38YZxeMRmWEyRwqFXCp+O38kOl9jwilEGTsiLvLos8ZNk05Wt5C05ya7sG2YNU49rmgKZjGxKNsuR905EpT4FLsK75q9gMXpuYkwHci;23:Mpp27jfmWsouW1nbdyXo7EibNsCocNnV5IxH1WRvPmZ+ycNFQXp1aPRqs++HWl1pe9grN38hUS+tD5ts6m6iGlvAnY8zAoowYIcYYEK6e+djhPh+Qs9n00T4Yy8lUWcLRl9S6sgxNvSmqe/755oCn5otKIeRgRODJ8At2mJGZes= X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(444111366)(82015058);SRVR:CY1NAM02HT104;BCL:0;PCL:0;RULEID:;SRVR:CY1NAM02HT104; X-MS-Exchange-Organization-SCL: 1 X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT104;6:u3yUnRb28n0VtEevwXmRFGAWQ5WdMWytJ08oYw3oGhgv9zEO82MJZQwy9R+VpFBHYN7lZ/oojk1FBI5GvImb7wlk7IMoM4O6GFQyvPvdH2nJCulV2RmqRETnvTj7cYBnvf4TCwViupWIKDoQaJ/xPZITBuqAbtYDl4GToLDHHODpOusyQLjARYkxjDOB2JRcylC1X7zYg09gimOGQPOyFjSeFjXBSiR4AN74FxQj4gK90KgMUjqgYnSDdcrxKccNJtsTcR6jysDIRmQO8WdD0C64idx7K8tXEomu8ztmKI6nDKJs/ExJdGM8fZli5YUW7P5yHZwt6x7d+/cTdTfDy3Loul9SnO7K406Ox/oce//DQsvqv7qFSJyNwwFJ+TUSGHcjD4zvkqLrLaK4bid2ow==;5:JWblK/G9NH0fuMnIUPQsWhTUKFH22OVUXKW+T2zUP2kmwGL0C255xcoymmq26cAuyOSWx82Ha4YmdLmLauojd4wzAyDBhp/Csr9UvBdGv6VlbnbjsTro6lGYfmmGTdY2uCOy5KTQOBWweV28beq+B0HZk5DhWmJwBAyMoO1RNWk=;24:66bGhJfbprBu248nT/InJm88ePKC1doOGXc6Zxq0Mq+MbJJG9ZRA87c+m2ryhu8SfbMYsbNwYp35PvGrv5vFnQhwoJsm7ZXIzCK1+Bn6stI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02HT104;7:f6j0OpexS3PL2ejlucl6U6O/qleKCsYvzwRzMZtycfn9rz8HJMJWIPxLNbXVqTai5GIwwM5wrXhUp2QAZc0aWTMdOSfi6nz+isu6euCYCtO/K48KUmGa8p/dfAybvGx52aWlNWwms3Oj5qpP6ASt7+4JC6/JdDkEBpHtin5jBrYc1rp+svNaYhPPHZdX0J9myret2Tkj/OSH3Va0LIgjBt7wXqE7SBhmhfIXk3HmZ2B0EXPKy1pyaWqe6YX/W5BVtcjORTmpNn1i4aid6qNkILJBeiSYElTR4L9OOU0BdLuFakSJXl0C/WtsZTbAZ/LCqg6Z8DPly/f2oRLmkVhfrg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2017 15:54:37.1010 (UTC) X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT104 X-MS-Exchange-Transport-EndToEndLatency: 00:00:00.5333641 X-Microsoft-Exchange-Diagnostics: 1;BN6PR18MB1268;27:GV+LQHWp6AhuAMXPkCuPcTME6qOjddBhry6WrI5w7LWNFf8Ihg85Q354zoiKKfQ73l9F/g7yIvE9Wj2Q+b/UMCTGmPuzsJc1RHwND6ivmL2WqsPOHCueoD55Bt5RqRh2cyv3IX6eoyqbe0UsEVrTgg== X-Microsoft-Antispam-Mailbox-Delivery: abwl:0;wl:1;pcwl:1;iwl:0;rwl:0;ex:0;auth:1;dest:I;WIMS-SenderIP:209.132.181.2;WIMS-SPF:fedoraproject%2eorg;WIMS-DKIM:fedoraproject%2eorg;WIMS-822:updates%40fedoraproject%2eorg;WIMS-PRA:updates%40fedoraproject%2eorg;WIMS-AUTH:PASS;ENG:(5061607094)(102400140)(102409045);OFR:TrustedSenderList; MIME-Version: 1.0

The following comment has been added to the audacity-2.1.3-2.fc25 update:

bodhi - 2017-04-02 15:54:33.387138 (karma: 0) This update has been submitted for stable by bodhi.

To reply to this comment, please visit the URL at the bottom of this mail

================================================================================ audacity-2.1.3-2.fc25

Update ID: FEDORA-2017-a20103b1c8 Release: Fedora 25 Status: testing Type: bugfix Karma: 3 Request: stable Bugs: 1397150 - None : 1423191 - None : 1413341 - None : 1408706 - None : 1402830 - None : 1398446 - None Notes: #Audacity 2.1.3 release. ##New Features: - MP3 import without : additional package repository. - Distortion effect, : Rhythm Track and Sample Data Import. - Scrub Ruler. - : Pinned waveform option. - Timer Record enhancements. : ##Other Changes: - many bugs and annoyances resolved. : See [Audacity Team release announcement](http://www.au : dacityteam.org/audacity-2-1-3-released/). Submitter: dtimms Submitted: 2017-03-26 05:57:00.163080 Comments: bodhi - 2017-03-26 05:57:00.257780 (karma 0) This update has been submitted for testing by dtimms. bodhi - 2017-03-27 03:21:03.590619 (karma 0) This update has been pushed to testing. dhgutteridge - 2017-03-27 13:53:01.674237 (karma 1) No regressions noted. (The microphone input slider doesn't respond, it's stuck at 100% -- and it doesn't reflect the actual state of the microphone input setting -- but that's not a regression from the previous version, audacity-2.1.3-0.7.20161109git53a5c93.fc25.) baggypants - 2017-04-01 09:19:12.432999 (karma 1) Loads and runs as expoected applied a couple of effects to an mp3 seems ok sassam - 2017-04-02 15:54:32.109649 (karma 1)

`

dhgutteridge commented 7 years ago

As an update, this is still happening with Bodhi 2.5.0.

bowlofeggs commented 7 years ago

@dhgutteridge Does this happen with every e-mail you receive from Bodhi, or just from some?

FWIW, I've not personally experienced this issue and I haven't heard from anyone else who has. If it happens for every single Bodhi comment (or for most) for you, we might be able to do some live experimenting to figure it out.

dhgutteridge commented 7 years ago

@bowlofeggs: it happens consistently whenever the final necessary +1 karma is applied to a package that is presently pushed to testing and has autopush enabled, whether that karma is from me or anyone else. It's curious that no one else is seeing that, I wonder if there could be some vestigial setting in my profile that's interacting with Bodhi? (I know nothing about that.)

I could sit on packages I've tested and wait to be the final +1, though that's a competitive game with some of them!

bowlofeggs commented 7 years ago

@dhgutteridge Whoah this issue just happened to me, so it's not just you! I got two e-mails about https://bodhi.fedoraproject.org/updates/FEDORA-2017-054e67a81c

bowlofeggs commented 7 years ago

I spent a few minutes looking at the code that adds the comment, and I don't quickly see the problem. The comment is only being added once to the update, so the code path that generates the e-mail is only being called once. The problem may be somewhere in one of these places but I'm not sure where at this point:

https://github.com/fedora-infra/bodhi/blob/2.5.0/bodhi/server/models.py#L1669-L1683 https://github.com/fedora-infra/bodhi/blob/2.5.0/bodhi/server/mail.py#L428-L508

dhgutteridge commented 7 years ago

Right, but technically there should be two emails sent, but they should have distinct messages in them. The first should show the comment from the person giving the +1 karma, and the second should indicate the package is being pushed to stable.

Before these duplicate emails started appearing, I'd consistently get two distinct emails, but often in opposite order, so the "pushed to stable" would come first, then the "+1" comment afterwards. (A.k.a. #1210.) My guess (without looking at the code, admittedly) was what's happening instead now is that Bodhi is determining the two emails need to be sent, but when it checks what to include, the final "pushed to stable" message is the content that's returned for both. There's some sort of timing issue occurring. From looking at sample emails I've received, both of the pair are sent after the "pushed to stable" has been recorded.

dhgutteridge commented 6 years ago

This is still an issue, only instead of being doubled at the point when it says "submitted for stable", it's now doubled at "submitted for batched".

keszybz commented 3 years ago

This is still an issue. E.g. in https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-90dcad2b89:

This update can be pushed to stable now if the maintainer wishes
8 hours ago (01:32:59 UTC)
This update has been submitted for stable by bodhi.
8 hours ago (01:33:01 UTC)

The first message is confusing for the maintainer.

Edit: The maintainer obviously is not going to react in the two seconds between the messages. But if it is important to let the maintainer know that the update can be pushed manually, even if the automatic push is later cancelled for some reason, the second message could be reworded to convey that additional info:

The update has spent enough time in testing, and can now submitted for stable. The update has been submitted for stable by bodhi.

keszybz commented 3 years ago

Another example: https://bodhi.fedoraproject.org/updates/FEDORA-2021-41aa39758c
Here the messages are in opposite order, i.e. first bodhi pushes automatically, and then it tells the maintainer that they are free to push.