search

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.
https://bodhi.fedoraproject.org
GNU General Public License v2.0
155 stars 196 forks source link

Rename the prefer_ssl setting #1921

Closed bowlofeggs closed 5 years ago

bowlofeggs commented 7 years ago

Bodhi has a prefer_ssl setting, which doesn't do what it sounds like it does at all because it's only used when libravatar_dns is True, and is only used by libravatar and not generally all of Bodhi. We should rename it to something that makes that clearer, like libravatar_prefer_tls.

This is a backwards incompatible change and should be done in an X release.

puiterwijk commented 7 years ago

Well, you could make a new setting and make it override the prefer_ssl setting if that's not set?

bowlofeggs commented 5 years ago

This change is planned for inclusion in the upcoming 4.0.0 release: #3221

bowlofeggs commented 5 years ago

Bodhi 4.0.0 beta is built and deployed to staging:

https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release https://bodhi.stg.fedoraproject.org/