search

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.
https://bodhi.fedoraproject.org
GNU General Public License v2.0
152 stars 193 forks source link

Using vagrant-lxc provider instead of vagrant-libvirt #2263

Open abitrolly opened 6 years ago

abitrolly commented 6 years ago

Is using lxc provider more beneficial in any way than libvirt? I thought that maybe lxc needs less memory or can take advantage of system installed packages?

bowlofeggs commented 6 years ago

This is a good example of what I mean by customizing your Vagrantfile in my comment on #2262 - Bodhi just provides an example Vagrantfile to get you started, but you are free to go and make any customizations you want to it from there on out.

One option might be to add a devel/Vagrantfile.lxc.example and rename the existing one to devel/Vagrantfile.libvirt.example, but the problem there is that I would then need to maintain two Vagrantfiles instead of just one. IMO, it's better for Bodhi to just keep things simple and provide a single example, but also be flexible enough to allow developers to customize as they please, and I believe the current implementation achieves that. What do you think?

abitrolly commented 6 years ago

Maybe single file https://stackoverflow.com/questions/17059982/multiple-providers-in-a-single-vagrant-file will be easier to maintain?