search

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.
https://bodhi.fedoraproject.org
GNU General Public License v2.0
152 stars 195 forks source link

Allow retriggering tests for all Fedora packagers #4151

Open bookwar opened 3 years ago

bookwar commented 3 years ago

It seems that currently onnly the owner of the Bodhi update can retrigger tests for it.

This prevents collaborative development, where updates can be managed by the SIG with multiple members, or proven packagers.

Please relax the restriction, so that any Fedora Packager can retrigger testsfor any Bodhi update

mattiaverga commented 3 years ago

Actually, the trigger_tests service uses the same permissions as for editing the update, which means that the user can edit (or re-trigger tests) is they have commit access to all packages included into the update, either as a user or by group membership.

So, if a user has commit access to a package, they should be able to re-trigger tests for an update even if the update was created by someone else. Can you point me to a specific case where this doesn't happen?

Or maybe you're hit by #4144 ?

bookwar commented 3 years ago

The issue is that it may be I don't have commit rights to the sources. But I am still a Fedora Packager working on a certain initiative. I don't think one must be a co-mantainer of the package to be involved in testing it.

Consider Fedora CI SIG use case: we have a team of people working on the CI issues and testing. None of us is a proven packager, but we need the possibility to retrigger tests on certain infrastructure problems.