Bodhi disallows buildroot overrides for updates that failed gating, which is a problem if you need one to fix the failed tests

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.

https://bodhi.fedoraproject.org

GNU General Public License v2.0

155 stars 196 forks source link

Bodhi disallows buildroot overrides for updates that failed gating, which is a problem if you need one to fix the failed tests #4661

Open AdamWill opened 2 years ago

AdamWill commented 2 years ago

See https://github.com/fedora-infra/bodhi/issues/2537 and https://bodhi.fedoraproject.org/updates/FEDORA-2022-092636385d . The tests failed because freeipa should be rebuilt against samba. The update fails gating because the tests fail. To make the tests pass we need a buildroot override for samba so we can rebuild freeipa. But we can't create a buildroot override because the tests failed.

Paging Joseph Heller...

AdamWill commented 2 years ago

I can work around this with side tags, but still, feels like an odd restriction.

mattiaverga commented 11 months ago

Looking back to this ticket, IMO this is the correct and expected behavior. We shouldn't allow to push a broken package (or one which breaks other packages) into buildroot. The correct way to handle such situations is to use a side-tag, build all packages in there and push a side-tag update.