Update.get_url() and abs_url() use `os.path.join` for some reason

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.

https://bodhi.fedoraproject.org

GNU General Public License v2.0

151 stars 191 forks source link

Update.get_url() and abs_url() use `os.path.join` for some reason #5566

Closed AdamWill closed 5 months ago

AdamWill commented 7 months ago

Uh, well. It probably isn't ever going to matter in practice, but if somebody ever tries running a Bodhi instance on Windows for some reason, and fixes every other thing they run into first, this might give them a shock...

AdamWill commented 7 months ago

(in case it's not clear, os.path.join has no business being used to construct URLs, which always use forward slashes whatever OS you happen to be running on)