Have the authentication policy honor config settings

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.

https://bodhi.fedoraproject.org

GNU General Public License v2.0

152 stars 195 forks source link

Have the authentication policy honor config settings #5572

Closed mattiaverga closed 9 months ago

AdamWill commented 9 months ago

Ideally this should also include a test, right? I believe there was a test before #5288 , which 5288 removed.

mattiaverga commented 9 months ago

Re added tests

AdamWill commented 9 months ago

LGTM.

mattiaverga commented 9 months ago

Cool, I'll merge this in the 8.0 and push a 8.0.1 out since this is really an urgent bug.

AdamWill commented 9 months ago

I guess it's a good thing I got completely lost in the auth flow trying to get logout / login to work in the dev env! In the end I couldn't even get that to work so I had to hack in a workaround, but at least I found this, heh.