search

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.
https://bodhi.fedoraproject.org
GNU General Public License v2.0
152 stars 195 forks source link

Fix Automated Tests table rows for absent and error results #5581

Closed AdamWill closed 9 months ago

AdamWill commented 9 months ago

This fixes my own oversight from https://github.com/fedora-infra/bodhi/pull/5480 . In changing the signature of make_row there, I did not remember to update all these other calls to it. This means make_row goes a bit crazy trying to treat 'FAILED' or 'ABSENT' as a subject and an error string or empty string as the outcome, and winds up rendering what looks to the user like an empty row. This should fix it so we actually get rows with sensible content again when a result is absent or there's some kind of remote rule error. Thanks to @decathorpe for finding this.

AdamWill commented 9 months ago

I tested this using https://github.com/fedora-infra/bodhi/pull/5565 (OBVIOUS SELF-PROMOTION IS OBVIOUS), slightly tweaked to force it to use the greenwave policy from earlier today, which was wrongly reporting a 'missing' result for F38 updates. It works - I can reproduce the bug without this fix, and with this fix, I see a correct table row for the missing result.