search

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.
https://bodhi.fedoraproject.org
GNU General Public License v2.0
150 stars 189 forks source link

tweak development.ini.example waitress to also listen on IPv6 #5659

Closed AdamWill closed 1 month ago

AdamWill commented 1 month ago

Per https://docs.pylonsproject.org/projects/waitress/en/stable/usage.html host = 0.0.0.0 binds only to IPv4. This is a problem for BCD if your system is IPv6-enabled and resolves http://localhost.localdomain to IPv6, not IPv4 - accessing the development environment server from your host may not work.

Setting the host to 'localhost' instead listens on both IPv4 and IPv6, so let's do that.

AdamWill commented 1 month ago

This seems to have been the thing causing problems for me locally, where I couldn't browse to http://localhost.localdomain:6543 with BCD any more. I found that I could do so if I disabled IPv6 in Firefox. Making this change seems to fix it so I can access it with IPv6 turned on. Note you do have to re-generate the BCD bodhi container after this change.

AdamWill commented 1 month ago

I have a follow-up which does similar changes to a whole bunch of other places where we currently specify 0.0.0.0, but I guess that's a bit more potentially disruptive, so I split this off as the minimal change needed to fix the BCD case.