search

fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.
https://bodhi.fedoraproject.org
GNU General Public License v2.0
150 stars 189 forks source link

Add new BuildRequires python3dist(poetry-core) in spec file and Fix wrong python_version in bodhi server httpd conf #5679

Closed kiraskyler closed 1 week ago

kiraskyler commented 2 weeks ago

fix issuse:

https://github.com/fedora-infra/bodhi/issues/5678

https://github.com/fedora-infra/bodhi/issues/5680

kiraskyler commented 2 weeks ago

@giallu @lmacken @ashcrow @brandongray could help me? thanks

mattiaverga commented 2 weeks ago

Hello @kiraskyler thank you for your contributions, good catch. There are a couple of things that needs to be adjusted. First, you must sign your commits with DCO, in the workflows table see the Details link in the DCO test row for details how to fix it.

Second, it would be nice to have the fixes announced in release notes as described here. You should add two files 5678.bug and 5680.bug with appropriate notes under the /news directory (add each file in the same commit with the fix by editing the commit).

kiraskyler commented 2 weeks ago

Hello @kiraskyler thank you for your contributions, good catch. There are a couple of things that needs to be adjusted. First, you must sign your commits with DCO, in the workflows table see the Details link in the DCO test row for details how to fix it.

Second, it would be nice to have the fixes announced in release notes as described here. You should add two files 5678.bug and 5680.bug with appropriate notes under the /news directory (add each file in the same commit with the fix by editing the commit).

Thank you for your guidance. I have signed my commits with DCO, At the same time, add PR5678.bug and PR5680.bug with appropriate notes under the /news directory.

mattiaverga commented 2 weeks ago

Rawhide tests are expected to fail ATM because Fedora Rawhide is currently broken due to the Python 3.13 rebuild. We just have to wait until that is fixed and I'll refresh tests, but everything looks good.