fedora-infra / bodhi

Bodhi is a web-system that facilitates the process of publishing updates for a Fedora-based software distribution.

https://bodhi.fedoraproject.org

GNU General Public License v2.0

151 stars 190 forks source link

critpath -1 karma is not reflected in overall karma #579

Open kparal opened 8 years ago

kparal commented 8 years ago

In this update https://bodhi.fedoraproject.org/updates/FEDORA-2015-15804 pschindl added -1 critpath comment to it. That's a response to question "Does the system's basic functionality continue to work after this update?". If the answer is negative, it means we have a serious problem somewhere. Yet it is not reflect in global karma, which still says 0 (instead of -1).

bodhi

We don't want to autopush updates where people give -1 critpath votes. Currently it seems Bodhi ignores that.

The general karma votes ("Is the update generally functional?") and critpath votes ("Does the system's basic functionality continue to work after this update?") should both affect overall karma vote. If any of those votes is -1, the overall karma vote should be -1.

trishnaguha commented 7 years ago

I think we can fix this issue and #829 if we can fix #879 . The PR is on the way https://github.com/fedora-infra/bodhi/pull/894

kparal commented 7 years ago

Thanks for working on this, @trishnaguha!

trishnaguha commented 7 years ago

894 makes sure that Autopush will be disabled automatically whenever a critical update receives negative karma.

@kparal @bowlofeggs Sounds like we can close this issue?

kparal commented 7 years ago

@trishnaguha Just to clarify, does bodhi now give -1 karma even for "Does the system's basic functionality continue to work after this update?" question?

bowlofeggs commented 7 years ago

@trishnaguha I don't think the -1 on the critpath question will count as a negative karma, so I don't think #894 will solve this particular issue.

trishnaguha commented 7 years ago

894 doesn't deal with critpath karma.

trishnaguha commented 7 years ago

To clarify my understanding regarding this issue, we want to make sure that Autopush is disabled if anyone gives critpath karma -1. @bowlofeggs @kparal right? Also we want to include critpath karma to total karma if it is negative which definitely sounds like some changes.

kparal commented 7 years ago

Also we want to include critpath karma to total karma if it is negative

Yes. If the user gives either karma -1 or critpath -1, the overall karma should receive -1.

we want to make sure that Autopush is disabled if anyone gives critpath karma -1

That's actually #833, also reported by me, proposed as a separate change. I'd also like to see that, yes. And this is not just about critpath -1, again it's karma -1 or critpath -1.

bowlofeggs commented 7 years ago

I think I agree with @kparal, it all sounds reasonable to me.

hroncok commented 4 years ago

I've noticed this and wanted to report it.

https://bodhi.fedoraproject.org/updates/FEDORA-2019-29c418b1d7

This update got 2 negative critpath karma and nothing happened. It was only when somebody gave -1 normal karma, where bodhi disabled automatic push to stable and the overall karma counter decreased.

(Note that the update was manually unpushed by the submitter.)

sebwoj commented 4 years ago

@ryanlerch Since karma_critpath is deprecated: https://github.com/fedora-infra/bodhi/blob/25cd8e7d211b3adab233c1712c6005ce1e0828a4/bodhi/server/models.py#L4209 can we close this issue?