search

fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

Only the message of an exception is JSON encodable #102

Closed relrod closed 9 years ago

relrod commented 9 years ago

Fixes another set of runtime errors…

ralphbean commented 9 years ago

I'll leave this one for @laxathom to look at.

Maybe other details of the error could be returned? The traceback is perhaps encodable? Should we return other context?

relrod commented 9 years ago

Well as it stands it throws runtime errors instead of JSON ;)

laxathom commented 9 years ago

Correct! pypingou meant to return it as json output. Ok, As I'm currently implementing the private API, I'm factoring a bit the API to handler both public and private requests, so if you see issue, I propose we sync up, does that work for you?

relrod commented 9 years ago

@laxathom Ok - are you fixing this issue in your refactor? Should I close this issue?

laxathom commented 9 years ago

Yep, you can close. Thanks for pointing this out.