Issue#96

[DhritiShikhar]

Creates a requirements.txt

[laxathom]

Sound good.Will merge it manually to only take the latest.

[laxathom]

@ralphbean you mean at line 238?

[ralphbean]

@ralphbean you mean at line 238?

Yes :)

[DhritiShikhar]

@ralphbean could you please take a look at the patch?

[laxathom]

sound good for real now :) :+1:

[ralphbean]

This still looks incorrect to me. Once again, the value of self.valid_ssh_key is not being interpolated into the regex pattern.

This would only match ssh keys that have the literal string "valid_ssh_key" in them, which is not what we want. We want to match keys that have the literal strings "rsa" or "ssh-rsa" or "ecdsa", etc.. So, those strings are in a variable named valid_ssh_key which needs to be interpolated into the regex pattern before it is applied.

[laxathom]

hm, that's actually what the the .replace() does by adding the "|" which stand for OR. I did try it myself from a python console and it does works as expected.

[pypingou]

@laxathom it's the re.match() line that's problematic

[laxathom]

Ah, stupid me! Saw the passed string instead of the variable.

[laxathom]

hm, do not copy/paste my line. some caracters got stripped by markdown

[DhritiShikhar]

@laxathom could you please check if the patch is alright?

[pypingou]

@laxathom ping ?

[laxathom]

Sorry for the delay. Just did a manual merge by squashing your commits.