search

fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

[l10n] Localization is lost on login #139

Closed Jibec closed 7 years ago

Jibec commented 8 years ago

Hi, 1/ https://admin.fedoraproject.org/accounts/ 2/ select "fr" for locale 3/ login 4/ text is in English because my profile default is "locale=en"

=> I find weird

can we make those fix ?

btw, that "locale setting" is interesting, does it have some usages in other context ?

Jibec commented 8 years ago

Any hope to improve this situation @ralphbean ?

pypingou commented 8 years ago

@Jibec for FAS you probably want to ping @laxathom actually ;-)

laxathom commented 8 years ago

Hmm, why weird? The app switches to your locale once logged in as its reads from your personal info/configuration which is higher than the default one (on welcome's page, when not logged in) and adapts its behavior and views based on that.

In the other hand, I can agree that, once logged in and then you change the locale, the app should switch to the one you selected.

btw, that "locale setting" is interesting, does it have some usages in other context ?

It should and - I hope - will ;) We try to make the account management more "centric" in a way that people can have one point of configuration (not for everything of course) avoiding them to update their personal/common info for each single fedora project's app.

Jibec commented 8 years ago

thanks for your answer @laxathom

to make it easier to understand by users, can you please add the "locale" setting when viewing a profile ? https://admin.fedoraproject.org/accounts/user/view/jibecfed

at the moment you need to edit your settings to see it, which make it difficult for user to understand why the language is changing before and after login.

pypingou commented 7 years ago

Why closing, is this fixed?

Jibec commented 7 years ago

I understand a FAS rewrite is going on and I already asked to be able to translate it: https://github.com/fedora-infra/fas/issues/142

If this little issue hasn't been fixed in a year, it may mean there is not sufficient ressources or that the modification isn't so easy to fix or whatever else.

In addition, I understood after this ticket that Fedora contributor tools are pretty much unstranslated on purpose (it cost and english is the working language).

As this isn't a huge issue, I prefer to close it. We'll discuss this once FAS3 is ready. Is it OK for you?

laxathom commented 7 years ago

works for me.