search

fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

Allow searching users by their email instead of doing it only by nickname #165

Closed pypingou closed 8 years ago

ralphbean commented 8 years ago

How about adding by_ircnick too? :)

pypingou commented 8 years ago

Sounds like a good idea we should just remember that for now FAS2 doesn't enforce unique irc nick :)

pypingou commented 8 years ago

One thing I was thinking of for this PR, check if there is a '%' in re_search and only use ilike() if there is, other use a plain ==

pypingou commented 8 years ago

by_ircnick implemented in stg at https://admin.stg.fedoraproject.org/accounts/user/list/kev*?by_ircnick=1

ralphbean commented 8 years ago

LGTM! :+1: