Issue #173: if the irc nick field is empty set it to None instead

[skrzepto]

173

If the irc nick field is empty set it to None instead

[pypingou]

:+1: for me

[pypingou]

We may want to .strip() while at it, unless it's already done somewhere (and that might be true for more fields)

[skrzepto]

Forgot about that edge case, let me test locally to see if it faults.

[pypingou]

let me test locally

Unit-tests!! Ok I'm out :D

[skrzepto]

let me test locally

Unit-tests!! Ok I'm out :D

Soon :) still trying to fully understand how fas works

[skrzepto]

Looks like the other unique fields have some kind of client verification. I'll look into writing unittests now to this

[laxathom]

Have you looked at defined a default None here https://github.com/fedora-infra/fas/blob/FAS_3.0/fas/forms/people.py#L166 see if this work? This might avoid to add am if statement on the register.

[skrzepto]

@laxathom unfortunately the default None doesn't help at least doesn't pass the unit tests I wrote. But this change does

[skrzepto]

Any comments on this?

[skrzepto]

@bowlofeggs I applied you feedback, thanks :) are we good to merge?