search

fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

[FAS3] Unique contrant failed on people.email when two accounts are created with exact info #178

Closed skrzepto closed 3 years ago

skrzepto commented 8 years ago

When creating an account with exactly the same info the program crashes to a debug screen. What should happen is we should warn the user that the email is already taken instead.

skrzepto commented 8 years ago 
IntegrityError: (sqlite3.IntegrityError) UNIQUE constraint failed: people.email [SQL: u'INSERT INTO people (username, password, fullname, ircnick, avatar, avatar_id, introduction, postal_address, country_code, locale, birthday, birthday_month, telephone, facsimile, affiliation, bio, timezone, gpg_fingerprint, ssh_key, email, recovery_email, bugzilla_email, email_token, unverified_email, security_question, security_answer, login_attempt, password_token, old_password, certificate_serial, status, status_timestamp, privacy, email_alias, blog_rss, latitude, longitude, fas_token, github_token, twitter_token, login_timestamp, creation_timestamp, update_timestamp) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)'] [parameters: (u'simon', '$2a$10$TTUCo9EU.CI6p6Rq8GqNx.vE/oT1mIMrNVD3sdAgHPj7/uqgaMANq', u'simon', u'', u'', None, u'', u'', None, u'en_US', None, None, u'', None, None, None, u'UTC', None, None, u'simon@gmail.com', None, None, None, None, u'-', u'-', None, 'ba2eb36d81d60cf13775da80d3517eda60e74dd5', None, 1, 3, '2016-07-15 15:25:58.465140', 0, 1, None, None, None, None, None, None, '2016-07-15 15:25:58.465149')]
laxathom commented 8 years ago

Hum... this should be already handled by https://github.com/fedora-infra/fas/blob/FAS_3.0/fas/forms/people.py#L122-L128

Need to double check then.

skrzepto commented 8 years ago

ahh I figured out how to reproduce the error.

When you create two accounts with exact same data then it faults like this.

If if everything but the emails are different the there's a warning Email: simon@gmail.com exists already!

ryanlerch commented 3 years ago

Closing this issue as the FAS project is now archived, not actively developed, and unmaintained.

FAS was replaced in March 2021 by Fedora Accounts (https://accounts.fedoraproject.org).

If this issue is a Feature Request that you forsee might be beneficial to Fedora Accounts, please refile it against Noggin