Closed pypingou closed 7 years ago
The amount of changes has increased quite a bit there ^^
One remark, otherwise looks sane
login still doesnt work. try logging into fasadmin, the first time it works, the second time it fails with the same error as i reported.
I think the UTCDateTime
implementation was actually correct
hm...lemme guess, you're using an SQLite engine, right? I know that SQLite has a lot of caveat on datetime and sqlalchemy provides its own datetime impl for SQLite datetime formatting.
i think your right. we should then remove sqlitte from the *.ini files so no one accidently comes across these issues and force postgres as the dev db
link to src http://docs.sqlalchemy.org/en/latest/core/type_basics.html#sqlalchemy.types.DateTime.__init__
Just confirmed this works in postgresql. If we just make a note in the readme about using postgres only then I'm okay with this PR.
@laxathom @pypingou
Are we deciding to stick with postgres for dev and prod db? This will solve the tz aware issue that is caused by sqlite.
I think we should stick to postgres yes
@laxathom thoughts?
:+1: here. However, let's not close the door to other DBAPI if people come around with a way to support them (MySQL, Oracle and the like)
@laxathom I think I read somewhere that MySQL has the same issues with storing timezone aware as sqlite. We can look at https://pypi.python.org/pypi/SQLAlchemy-UTCDateTime/ just not sure if we want to do that or not. Thoughts?
@skrzepto let's open a discussion ticket to check this so we can move forward, merge and close this PR
lgtm as well
Let's merge then :)
:+1: from me. The utc thing works from a scratch fas3's db and a fas2's migration my side. Need to validate this on staging though.