fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

Added a simple Vagrant setup for hacking on FAS3 #220

Closed ryanlerch closed 7 years ago

ryanlerch commented 7 years ago

Fixes #208

ryanlerch commented 7 years ago

@skrzepto thanks!

I have updated the Vagrantfile to use postgres rather than sqlite.

--ryanlerch

ryanlerch commented 7 years ago

okies, it now uses fedora25 cloud.

ryanlerch commented 7 years ago

Just updated the Vagrant setup to use ansible as the provisioner, rather than shell scripts. This is how we do it in other places like bodhi.

ryanlerch commented 7 years ago

Just added liberation-mono-fonts as a requirement for teh Vagrant provisioning process. See #146 for why.

ryanlerch commented 7 years ago

Just squashed all the previous commits into a single commit on this branch.

puiterwijk commented 7 years ago

Other than that I hate Vagrant (it doesn't work at all with rpm-ostree setups due to messing around with plugins files and all kinds of other messy stuff), this patch looks fine to me. :+1:

Perhaps it's an idea to move Vagrantfile to Vagrantfile.example though, since some people (e.g. me) will need to modify the vagrantfile before they can run it.

laxathom commented 7 years ago

I think you can remove the playbook.retry file. I'd encourage to have all those file into a dedicated rep though or rename devel to something else to better match what is inside (ansible's files). Other than this, look good to me.

ryanlerch commented 7 years ago

Okay,

I kept the ansible files in the devel directory, as this is how is it set up in other repos in Infra. I was using the bodhi Vagrant/ansible setup as a guide to try to keep these setup in similar ways.

laxathom commented 7 years ago

I kept the ansible files in the devel directory, as this is how is it set up in other repos in Infra. I was using the bodhi Vagrant/ansible setup as a guide to try to keep these setup in similar ways.

Okay, then, why such a name? I find it quite confusing. devel is a short for development afaik. 95% of the files are development's files. If I follow this logic, I should put everything single development related file into that directory.

ryanlerch commented 7 years ago

Okay, then, why such a name? I find it quite confusing. devel is a short for development afaik. 95% of the files are development's files. If I follow this logic, I should put everything single development related file into that directory.

My interpretation of the name is that it is so people don't assume that it is production-ready ansible setup, but instead designed for development. how would you feel about renaming the folder devel-ansible ?

jeremycline commented 7 years ago

I recently updated the Vagrant Fedora wiki with the Vagrantfile I typically use, if you want to peruse it. The main differences between it and the one included here are:

Just an FYI 😃. I think this looks fine to get started with.

ryanlerch commented 7 years ago

Thanks @jeremycline !

Once we get this one merged, I will look into adding these features.

ryanlerch commented 7 years ago

@laxathom can merge this one now?