search

fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

Move themes to own directory #227

Closed ryanlerch closed 7 years ago

ryanlerch commented 7 years ago

This PR moves the templates and the static files for a theme into a new theme/ directory. This moves the current theme into theme/default/static and theme/default/templates.

This will allow us to add new themes into the theme/ directory. There is also a new config added to the ini file, global.theme.name, which is used to populate the static paths and template paths further down in the ini file automatically. the theme name matches the directory in /theme/.

There is also a new variable theme_static that is available to the templates that provides the static directory that is defined in the ini file, so these paths dont need to be hard coded in the templates.

laxathom commented 7 years ago

You also need to update theme and themePath from fas/front/theme/config.js, FONT_DIR from fas/front/theme/Makefile Other than that, looks good to me :+1:

ryanlerch commented 7 years ago

Okies, updated the paths, going to merge this one now!

ryanlerch commented 7 years ago

One extra thing we could do in the future here too is to move the fas/front/ into the default theme itself. (i.e. theme/default/front)