fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

Add two IRC-related fields to the people model #255

Closed jeremycline closed 7 years ago

jeremycline commented 7 years ago

Fedora Hubs wants to offer an easy IRC experience for users who opt in to it. This adds two fields to the People model. irc_enabled is the flag to indicate whether the user wants to use the Fedora-provided IRC bouncer, and irc_password is the Freenode password used to identify the user. ircnick will be used to determine the nick to use and email can be used for the registration email.

For more context, see:

Do I need to add tests, and if so, where?

laxathom commented 7 years ago

While this sounds like a nice feature I don't see how this can help Hubs to store those info account-side w/o providing the account system a way to manage them and specifically on the password's from which we don't know how it will be stored (plain, hash, etc).

If this needed to be account-side, the account system has to provide to its registered user a way to alter those info w/o having to go to a 3rd-party app. Which means this info need to be view-able from the profile account and the user can update/deactivate it from there as well.

There actually is more work to do for this feature than just add two fields to the data model.

jeremycline commented 7 years ago

We ended up chatting about this and deciding to track it all in hubs.