fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

Disallow logging in by providing email address as username #263

Closed puiterwijk closed 6 years ago

puiterwijk commented 7 years ago

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

nirik commented 7 years ago

+1 here, looks good to me.

puiterwijk commented 7 years ago

This is a "feature" that some people might be using, but we are going to lose it anyway if we move to another backend down the road. I considered waiting for that to happen, but that'd likely be such a huge change that I don't want things like this in the same change.

nirik commented 7 years ago

We should look at moving the wiki over to openid before we land this, as thats a place people likely use email still.

pypingou commented 6 years ago

I believe this can be merged now