search

fedora-infra / fas

Fedora Account System
https://admin.fedoraproject.org/accounts
GNU General Public License v2.0
40 stars 50 forks source link

Add specificity to new account note #270

Closed stickster closed 6 years ago

stickster commented 6 years ago

Making the implications clearer for privacy.

laxathom commented 6 years ago

Note that this changes are against translate-able words which imply them to be reflected into translation files as well. You would need to update those files for the PR to be changes-complete. See https://github.com/fedora-infra/fas/blob/support/0.14.x/HACKING#L221

stickster commented 6 years ago

I updated the POT. Note there are some changes in POT strings I didn't originate.

laxathom commented 6 years ago

Thanks @stickster ! Will check the pot file locally.

laxathom commented 6 years ago

Ran the pot update locally and didn't get the same diff as yours. If you look closely at your changes, the whole translated text get removed but your updated updates one.

Woud you mind double check this by running this cmd-line to rebuild the file?

pybabel extract -F pybabel.conf -o po/fas.pot fas/

thx

stickster commented 6 years ago

@laxathom Any better now?