Add multivalue to website and rssurl fields

fedora-infra / fasjson

GNU General Public License v3.0

8 stars 15 forks source link

Add multivalue to website and rssurl fields #720

Closed phsmoura closed 6 days ago

phsmoura commented 1 month ago

Fixes #719

Proposed Changes

Make rssurl and website multivalued fields

Verification Steps

It needs to pass unit tests at least. List type were added to those fields in test_lib_ldap_client.py

abompard commented 1 month ago

Apparently Black wants to reformat a file, please run it (or run pre-commit install which will run it on each commit).

abompard commented 1 week ago

Quick question: in the planet script, how do you plan to retrieve the list of users that have a RSS feed configured?

phsmoura commented 1 week ago

Quick question: in the planet script, how do you plan to retrieve the list of users that have a RSS feed configured?

It's using subprocess to execute curl and retrieve that information. You can find the script line here An update is needed to handle the array for the new multi-valued rssurl(s) attribute, but this has already been implemented locally. We just need this PR to be merged to test it.

abompard commented 6 days ago

It's using subprocess to execute curl and retrieve that information. You can find the script line here

OK, I have a suggestion for this script to make it only return users that have a RSS feed configured, would you be interested? Also, I can propose a way to do it in Python instead of forking a curl binary. If you're interested, tell me and I'll send you a PR.