search

fedora-infra / fedmsg

Federated Messaging with ZeroMQ
https://fedmsg.readthedocs.io/
GNU Lesser General Public License v2.1
171 stars 93 forks source link

Fix default type check #500

Closed sijis closed 6 years ago

sijis commented 6 years ago

While working on #499, I noticed some discrepancies in the validation of the configs in FedmsgConfig.

This attempts to address those discrepancies.

I used the generated output from fedmsg-config as the source of truth on what these values should be.

sijis commented 6 years ago

Updated references of relay_inbound to be strings.

codecov[bot] commented 6 years ago

Codecov Report

Merging #500 into develop will decrease coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #500      +/-   ##
===========================================
- Coverage    60.28%   60.17%   -0.12%     
===========================================
  Files           29       29              
  Lines         1750     1750              
  Branches       272      272              
===========================================
- Hits          1055     1053       -2     
- Misses         618      620       +2     
  Partials        77       77
Impacted Files Coverage Δ
fedmsg/core.py 45.6% <0%> (-1.1%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da90440...32e6e05. Read the comment docs.

jeremycline commented 6 years ago

Great, thanks for this!