GitHub long form processor includes the patch which could be huge

fedora-infra / fedmsg_meta_fedora_infrastructure

fedmsg metadata providers for Fedora Infrastructure's deployment

GNU Lesser General Public License v2.1

15 stars 47 forks source link

GitHub long form processor includes the patch which could be huge #464

Open jeremycline opened 6 years ago

jeremycline commented 6 years ago

Take, for example, https://github.com/jflory7/blog-images/commit/fb2dcd6654709ff01af0fea510adc560ef5569f0 which is a 20MB image. This resulted in fmn trying to send out emails with the patch in the body which ended poorly.

I doubt anyone wants to get a diff for a binary file that could be up to 100MB (GitHub's apparent file limit) so maybe fedmsg_meta should check the content-type or something.