search

fedora-infra / fedora-messaging

A library for sending AMQP messages with JSON schema in Fedora infrastructure
GNU General Public License v2.0
50 stars 51 forks source link

Enhancement: use mypy #133

Open abompard opened 5 years ago

abompard commented 5 years ago

MyPy is pretty cool, we should adopt it.

anshikavashistha commented 3 months ago

@abompard please assign this issue to me

anshikavashistha commented 3 months ago

@abompard We could use mypy for checking typing in python.We might add it to test and add typing library to code as mypy is an optional static type checker for Python that aims to combine the benefits of dynamic (or "duck") typing and static typing.

anshikavashistha commented 3 months ago

@abompard Would there be any reference to this issue? Please share It would be very helpful for drafting the PR

anshikavashistha commented 2 months ago

https://github.com/fedora-infra/fedora-messaging/pull/352 This is with reference to Enhancement of MyPy.

anshikavashistha commented 2 months ago

@abompard The PR is still in progress I am trying to integrate mypy with tests at fedora-messaging.

anshikavashistha commented 2 months ago

Gradually adding the type hint to the fedora messaging codebase