search

fedora-infra / fedora-messaging

A library for sending AMQP messages with JSON schema in Fedora infrastructure
GNU General Public License v2.0
52 stars 52 forks source link

Update installation.rst #338

Open nwekealex65 opened 4 months ago

nwekealex65 commented 4 months ago

Add documentation for passive_declares config value. fixes issue #245.

This pull request aims to fix issue #245 which addresses documentation for configuring Fedora Messaging by adding a passive_declares option to be set true for vhost users

Changes Made Added a reminder to the installation.rst file emphasizing the importance of setting passive_declares to true in the Fedora Messaging configuration. Provided clear instructions for users to locate the /etc/fedora-messaging/config.toml file and set the passive_declares option to true.

nwekealex65 commented 4 months ago

Not sure why the tests are failing

abompard commented 4 months ago

Not sure why the tests are failing

you can ignore the rpm-build and testing-farm failures for now. Please use "-s" to sign your commits, this will add a Signed-Off-By tag in the commit message and the DCO test will pass.

nwekealex65 commented 4 months ago

Did you review the documentation? All test passes now. Does it mean the pull request has been merged?

abompard commented 4 months ago

The DCO test is still not passing, see my comment above.

nwekealex65 commented 4 months ago

The DCO test is still not passing, see my comment above.

Okay seen