search

fedora-infra / fedora-stats-tools

CLI tools for makings graphs of Fedora Infrastructure's datagrepper data
https://apps.fedoraproject.org/datagrepper
10 stars 10 forks source link

Meetbot_stats #4

Closed bee2502 closed 8 years ago

bee2502 commented 8 years ago

A few lines in script have been tweaked for file writing. Sample Results files(monthwise.txt , weekwise.txt , daywise.txt ) are also updated in the /scripts

decause commented 8 years ago

If you're going to list the dates going back in time, it may be a good idea to output and add the datetime that the script was run at, so that the data has some context?

@ralphbean since you've written the orig, how about a quick peek?

ralphbean commented 8 years ago

it may be a good idea to output and add the datetime that the script was run at, so that the data has some context?

Sure. That would make sense.

pypingou commented 8 years ago

hm, are we mixing tabs and spaces in this file here?

ralphbean commented 8 years ago

Friendly tip, @bee2502: use more specific messages and what you changed in your commit messages. Otherwise, it is hard to look at the history of commits here (and elsewhere) and quickly know what changed, and why.

bee2502 commented 8 years ago

@ralphbean , @decause : I have updated the indents and edited the code to provide timestamped values. I have also added a sample file for monthwise results "TimeStampedMonthwise.txt". Please look into it.

Other than that - @ralphbean 's earlier code as well as the current script take the current time as input and find daywise/weekwise/monthwise results. Since, the script runs serially, the initial starting time for queries for all topics of a particular type(say monthwise) is not same. (Please check out the last part of 'TimeStampedMonthwise.txt' ) and also some time period is omitted. Do you think we should fix this issue by defining a universal start time for all topics/types and updating the time period accordingly or is this issue negligible ?

@pypingou : Updated the code . Thanks :)

ralphbean commented 8 years ago

@decause any thoughts on this? You get the final say in a merge, I think.

decause commented 8 years ago

If you're +1, I'm +1.

:shipit: On Oct 23, 2015 12:10 PM, "Ralph Bean" notifications@github.com wrote:

@decause https://github.com/decause any thoughts on this? You get the final say in a merge, I think.

— Reply to this email directly or view it on GitHub https://github.com/fedora-infra/fedora-stats-tools/pull/4#issuecomment-150620661 .

bee2502 commented 8 years ago

@decause , @ralphbean : If possible, can we wait to merge? I want to add some meetbot topics not mentioned in the docs : https://github.com/fedora-infra/supybot-fedmsg/commit/47339f5741192cb0a2f5b65277cbce0d7c529bed Documentation : https://fedora-fedmsg.readthedocs.org/en/latest/topics.html#meetbot

bee2502 commented 8 years ago

Updated the code and results with new topics not available in documentation : https://github.com/fedora-infra/supybot-fedmsg/commit/47339f5741192cb0a2f5b65277cbce0d7c529bed

ralphbean commented 8 years ago

LGTM. :+1: