search

fedora-infra / fedora-tagger

Small tagger app for Fedora Community
https://apps.fedoraproject.org/tagger/
15 stars 23 forks source link

Update links away from pkgdb #201

Closed alick closed 6 years ago

alick commented 6 years ago

I think this will work, but I haven't tested it locally. When I tried to set up a local instance following the README.rst, I stuck at no mkvirtualenv command.

pypingou commented 6 years ago

no mkvirtualenv command.

dnf install python2-virtualenvwrapper :)

alick commented 6 years ago

@pypingou I did install the package. Is it because I was running Fedora 26?

pypingou commented 6 years ago

Without more information about what happened I cannot tell

alick commented 6 years ago

Anyway, I upgraded to Fedora 27 and now I do have mkvirtualenv now.

cverna commented 6 years ago

This LGTM, @pypingou you want to have a look ?

pypingou commented 6 years ago

It looks fine to me as well, but @alick were you able to test it live finally?

alick commented 6 years ago

I haven't. Will try tonight.

alick commented 6 years ago

Hi, I've tested it locally, and the (absolute) links work fine, after fixing two more typos.

alick commented 6 years ago

@pypingou I've updated the commit. Now all links are absolute links.

cverna commented 6 years ago

:+1: Thanks