fedora-infra / fedora-tagger

Small tagger app for Fedora Community
https://apps.fedoraproject.org/tagger/
15 stars 23 forks source link

Please refresh card once tag is added #98

Open pnemade opened 11 years ago

pnemade commented 11 years ago

Whenever I add a tag to any package, its card does not get refresh and does not show tag added by me.

ralphbean commented 11 years ago

We currently only display a random 5 tags for a given package.

The reason we do not do a refresh currently is: "How do we handle the case where a package has 200 tags?"

If we refreshed after a user added one, what if theirs didn't appear in the randomly selected list of 5?

What if the user adds 10 new tags in one go? We can't display them all at the same time.

pnemade commented 11 years ago

Hmm. Haven't thought that case. The next question is consider a package which got 200 tags or more that 5 tags and I got a chance to vote on it in Tagger. On what basis tagger is going to show me tags( is it limited to 5 tags)? I may loose some voting for some tags which will not be displayed then.

ralphbean commented 11 years ago

Yup. It is limited to 5 tags and is random each time you load the page.

You could just hit F5 or refresh the page to see if you get any others.

pnemade commented 11 years ago

Thanks. You can close this issue.

ralphbean commented 11 years ago

Cool, cool. Thanks for all the feedback and tickets. It helps a bunch for organizing workflow.

relrod commented 11 years ago
15:21:36 < relrod> [...] Can't we add them to the bottom and shift the old ones up? If they add a bunch, just show the last 5.
15:21:52 < threebean> relrod: cool.. can you add that comment to the ticket and re-open it?

done, :)

ralphbean commented 10 years ago

I'd like to double-back here and suggest that this be closed again as wontfix. As I look at it now, it just seems like the amount of work it would take to pull it off won't be worth the benefit.

If there's still interest in seeing this implemented, just chime in here indicating as much.

relrod commented 10 years ago

I still think this would be nice. I can try to send a patch at some point if nobody else gets to it.