It's a bit too easy to miss the final commit step, in creating a rule.

[ferdnyc]

When going through the steps of creating a new rule:

1. Click "Add a new rule"
2. "Choose a Tracking Rule" and set an optional "Rule Title"
3. Click the just-appeared "+Add Destination" button
4. Fill out the destination form and click "Add Destination" (again, but a different one)

...having done that, it's a little bit too easy to miss that you haven't actually created anything unless you hit the "Create Rule" button in the upper-right corner, which is what finally does the actual rule-creating.

If the user mistakenly thinks they've already set everything they need for their rule, and instead clicks the "Notifications" logo instead, the interface will (without so much as an "Are you sure?" prompt) happily wander away from the in-progress rule creation, discarding all of the just-configured parameters.

This perhaps somewhat ties in to #877, since having a visible Cancel button would hopefully make it more clear that there's an in-progress activity yet to be completed.

[penguinpee]

...having done that, it's a little bit too easy to miss that you haven't actually created anything unless you hit the "Create Rule" button in the upper-right corner, which is what finally does the actual rule-creating.

:+1: I just stumbled on that as well. It took me three attempts to figure it out. I think the button is mislabelled. It shouldn't be Create Rule, which implies creating another rule. How about renaming it Save Rule and maybe changing the color, so it stands out. Placing it below the rule creation box may also help. One usually navigates top to bottom. At the bottom it should show a Save button. Having it at the top, it's easily missed.

[ferdnyc]

I think the button is mislabelled. It shouldn't be Create Rule, which implies creating another rule. How about renaming it Save Rule

The more I think about it, the more I agree with this.

"Create Rule" would be appropriate if the rule-definition form was always present in the interface. Like, if the "My Rules" listing had a new-rule form directly beneath it, which you could fill out to define a new rule, then "Create Rule" — to transfer those form inputs into the list as a new rule — would make sense as an action button.

But after going through a multi-page, branching series of steps to build a rule definition, "Create Rule" is counterintuitive. You've already created the rule — that's what all of those steps were for. Now you want to commit the rule you've created, to make it active. "Save Rule" is probably the most obvious label for that action, or maybe something like "Activate Rule" or "Apply New Rule". But definitely not "Create Rule".

[Precious000]

Hi there! Please is it possible to work on this? I’ll like to work on it as an outreachy intern

[abompard]

Sure @Precious000, I've assigned it to you.

[Precious000]

Hi @abompard I need your help, I have forked the repo, can you please guide me which of the files I can find the said error, I have checked fedora_messaging, it doesnt seem to be in any of those files?

[abompard]

Hi @Precious000 , it's in frontend/src/components/NewRuleForm.vue