fedora-infra / koschei

Continuous integration for Fedora packages
GNU General Public License v2.0
37 stars 15 forks source link

Polling crashes when real build is untagged #263

Closed mizdebsk closed 6 years ago

mizdebsk commented 6 years ago

I've untagged real build in Koji, which lead to polling crash. I'm using koschei-backend-2.3.1-1.fc28.noarch.

Traceback:

Jun 12 05:21:58 koschei koschei-polling[31119]: Polling latest real builds...
Jun 12 05:22:00 koschei koschei-polling[31119]: Service polling crashed.
Jun 12 05:22:00 koschei koschei-polling[31119]: Traceback (most recent call last):
Jun 12 05:22:00 koschei koschei-polling[31119]:   File "/usr/lib/python3.6/site-packages/koschei/backend/main.py", line 50, in main
Jun 12 05:22:00 koschei koschei-polling[31119]:     svc(backend.KoscheiBackendSession()).run_service()
Jun 12 05:22:00 koschei koschei-polling[31119]:   File "/usr/lib/python3.6/site-packages/koschei/backend/service.py", line 81, in run_service
Jun 12 05:22:00 koschei koschei-polling[31119]:     self.main()
Jun 12 05:22:00 koschei koschei-polling[31119]:   File "/usr/lib/python3.6/site-packages/koschei/backend/services/polling.py", line 59, in main
Jun 12 05:22:00 koschei koschei-polling[31119]:     backend.refresh_latest_builds(self.session)
Jun 12 05:22:00 koschei koschei-polling[31119]:   File "/usr/lib/python3.6/site-packages/koschei/backend/__init__.py", line 605, in refresh_latest_builds
Jun 12 05:22:00 koschei koschei-polling[31119]:     _check_untagged_builds(session, collection, package_map, build_infos)
Jun 12 05:22:00 koschei koschei-polling[31119]:   File "/usr/lib/python3.6/site-packages/koschei/backend/__init__.py", line 530, in _check_untagged_builds
Jun 12 05:22:00 koschei koschei-polling[31119]:     .filter(Build.started > last_valid_build.started)
Jun 12 05:22:00 koschei koschei-polling[31119]: AttributeError: 'NoneType' object has no attribute 'started'
msimacek commented 6 years ago

Do you have a link to the build?

mizdebsk commented 6 years ago

Do you have a link to the build?

No. The Koji instance was transient and it's already gone.

msimacek commented 6 years ago

Actually, that gives me enough pointers. There were probably imported builds (no repo_id) involved.