search

fedora-infra / koschei

Continuous integration for Fedora packages
GNU General Public License v2.0
37 stars 15 forks source link

javacript error prevents modify settings #334

Open sergiomb2 opened 3 years ago

sergiomb2 commented 3 years ago

https://koschei.fedoraproject.org/package/debhelper?

Uncaught TypeError: can't convert Object to string _jQueryInterface https://apps.fedoraproject.org/global/fedora-bootstrap-1.0.3/fedora-bootstrap.js:3166 jQuery 2 _jQueryInterface https://apps.fedoraproject.org/global/fedora-bootstrap-1.0.3/fedora-bootstrap.js:3161 Collapse https://apps.fedoraproject.org/global/fedora-bootstrap-1.0.3/fedora-bootstrap.js:3212 jQuery 2

voxik commented 3 years ago

It seems that similar error prevents expanding the changed dependency list

mizdebsk commented 3 years ago

I am aware of this issue, but I have no idea what causes it as there were no changes on Koschei side. I suspect extarnal JavaScript bundle that is loaded from apps.fedoraproject.org changed.

hrnciar commented 3 years ago

Hello, is there any update on this?

mizdebsk commented 3 years ago

I was investigating this issue, but it is unclear to me what is causing it as there were no code changes in Koschei JavaScript code. It could be that fedora-bootstrap (which JavaScript code is imported by Koschei) was changed underneath. I intend to remove dependency on externally-loaded fedora-bootstrap and bundle all dependencies in Koschei itself, but I don't know whether that would resolve this issue.

mizdebsk commented 3 years ago

I found the cause of the issue, I'm working on a fix now.

mizdebsk commented 3 years ago

A hotfix has been applied in production deployment at Fedora infrastructure. A proper fix will be implemented later.

sergiomb2 commented 3 years ago

Thank you , it is working for me

mizdebsk commented 3 years ago

Thank you for confirming the hotfix, but the real issue is still not fixed in Koschei, so please leave this bug open for now.

hrnciar commented 3 years ago

Even though you can modify settings now, I think there is another issue. I am unable to set the package to be tracked. After I submit the form it still says Tracked by Koschei False. On the other hand, manual priority has changed but it doesn't seem like it triggered the actual build. E.g. this package https://koschei.fedoraproject.org/package/python-emcee?collection=f35

mizdebsk commented 3 years ago

The issue with tracked that cannot be changed was opened as a separate issue #336