fedora-infra / matrix-bots

Issue tracking & Development Envrionment for Fedora Matrix Bots
MIT License
3 stars 3 forks source link

Meetbot: improved link detection #22

Open MoralCode opened 5 months ago

MoralCode commented 5 months ago

Similarly to #21, it may be nice to allow meetbot to be able to detect more different ways links get posted and proactively ask for a confirmation (or look for a specific react) to decide if it should add that link to the meeting notes.

this could help eliminate an additional re-posting of links and allow meeting-organizers to skip typing the !link command so much

jwflory commented 5 months ago

I like this idea a lot. One possible user interface for this would be a trigger for any time a valid URL is sent during a meeting without using !link. Meetbot could reply with a message to something like this:

I see you shared a link just now. Did you want to include that in the meeting minutes? @message_sender:server.name, please react with 👍🏻 to this message to add it to the minutes. If you do nothing, the link will be ignored.

Or something like that. If the person who sent the original message with the link reacts to the bot's message with 👍🏻, then it could get automatically hitched into the meeting minutes without disrupting the meeting, or having a meeting chair to repost links using !link.

MoralCode commented 5 months ago

i guess there could be an edge case if multiple links are present in one message. maybe a better way would be:

  1. link posted
  2. if only one link: maybe bot posts helptext like justin suggested, but in a thread (and maybe the emoji is :link:, or customizable)
  3. if one link: bot looks for the emoji react on the original message
  4. if multiple links: bot reposts each link individually in the thread and looks for reacts on those

that does seem like a lot of extra checking but maybe its not as necessary or can be simplified if this isnt a particularly common thing

ryanlerch commented 5 months ago

This is another one for the upstream i reckon.

https://github.com/GregSutcliffe/maubot-meetings

Note that the !link command in the meetings plugin is (at the moment), just one of the "tags" -- which just allows a user to mark up a message with a certain tag in the meeting logs -- in theory you could !link something that isnt a link and it will work.

ryanlerch commented 5 months ago

If you want to just have a list of links that were posted in a meeting, you could generate that at the end meeting and append it to the logs.

IIRC, the whole idea of the !link command was so someone could mark a link as "important" not just to do all the links.